Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a version file in binary wheel packages #8

Open
nightlark opened this issue Mar 3, 2020 · 0 comments
Open

Create a version file in binary wheel packages #8

nightlark opened this issue Mar 3, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed python

Comments

@nightlark
Copy link
Member

Currently, versioneer uses git to determine the version number. This can result in a version of 0+unknown or for virtualenvs within a repository an incorrect version returned by helics.__version__.

One approach for fixing this is modify setup.py to output a VERSION file with the current version that it detects for inclusion in the installed HELICS package, then modify the helics/__init__.py script to check the VERSION file first before using versioneer.
@nightlark nightlark added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers python labels Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nightlark