Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize hard-coded Boost and MSVC version numbers for finding Boost install to use #2677

Open
nightlark opened this issue Oct 9, 2024 · 0 comments

Comments

@nightlark
Copy link
Member

In https://github.com/GMLC-TDC/HELICS/blob/develop/config/cmake/addBoost.cmake, the two hard-coded lists of Boost versions can be replaced with file(GLOB ...) to find folders matching the folder naming patterns. The version number can then be extracted from the matching folder names, and filtered using functionality CMake provides for comparing version strings to ensure a minimum Boost version is found.

For the MSVC library subfolder name, the MSVC_TOOLSET_VERSION CMake variable can be used by inserting a . before the last digit, to construct a folder name that doesn't require checking against the MSVC compiler version (e.g. CMake developers have already done the work to maintain a mapping between compiler versions and toolset versions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant