Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: EV example load oddly scaled #2666

Open
bpalmintier opened this issue Aug 5, 2024 · 2 comments
Open

Documentation: EV example load oddly scaled #2666

bpalmintier opened this issue Aug 5, 2024 · 2 comments
Labels
documentation Issues pertaining to missing documentation or errors in documentation

Comments

@bpalmintier
Copy link
Contributor

Describe the bug
In the documentation, the multi-port EV "advanced example" has unreasonable peak values, >20MW for 5 EVs, even

What is the expected behavior?
Consider that Tesla DCFC chargers are often around 100-200kW and the faster side of EV car max charge rates is ~300kW then even if all 5 ports were at max the peak would be around 1.5MW (about 10x less). Moreover such charging sessions also are simulated to last multiple days, which would not be common with anything close to DCFC. It might be relevant for Level1, but then the charge rates are around 1.5kW/charger. Certainly higher charge rates might be seen with M/HDV, but this doesn't seem to the the case in the description

To Reproduce
Review the output figures such as at https://docs.helics.org/en/latest/user-guide/examples/advanced_examples/advanced_brokers_multicomputer.html

Environment (please complete the following information):

  • On-line documentation

Additional context and information
(e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Generally love these examples, it would also help to somewhat increase the domain story of what is going on. In this case it is unclear how the batteries loose charge. Are they being driven? V2G, etc. And also why they seem to almost always be connected for over a week (168hr) which is unexpected since even at Level-1, folks would likely be charging only when at home and have extended times away. Even more so for DCFC where sessions might only last 20min and would fill up enough for a week or more of around town driving.

@bpalmintier bpalmintier added the bug Issue concerning incorrect code operation label Aug 5, 2024
@trevorhardy
Copy link
Contributor

I recommend moving this to the HELICS-Examples repo.

Can you clarify why you consider this a "bug"? Is it the lack of realism?

@bpalmintier
Copy link
Contributor Author

bpalmintier commented Aug 12, 2024 via email

@bpalmintier bpalmintier added documentation Issues pertaining to missing documentation or errors in documentation and removed bug Issue concerning incorrect code operation labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues pertaining to missing documentation or errors in documentation
Projects
None yet
Development

No branches or pull requests

2 participants