Skip to content

Actions in Graph Env #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josephdviviano opened this issue Mar 4, 2025 · 0 comments
Open

Actions in Graph Env #251

josephdviviano opened this issue Mar 4, 2025 · 0 comments

Comments

@josephdviviano
Copy link
Collaborator

josephdviviano commented Mar 4, 2025

Leaving a note here to ensure we address @hyeok9855's ideas:

Here, we define GraphActions as action class, but I think here we need to output Actions as in RingGraphBuilding.make_actions_class.

Thoughts on Actions and GraphActions

I believe the most complicated part w.r.t. Graph is the actions, where we have two kinds of actions - Actions, a class to take flat tensors from the policy, and GraphActions, another class to take steps in the GraphEnv. So we need a clear rule in designing these.

For example,

  • make_actions_class should always output the Actions so that it can take flat tensor,
  • Enforce users to implement convert_actions by making it as abstractmethod
  • step in GraphEnv should always take GraphActions

etc.

Originally posted by @hyeok9855 in #210 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant