[Bug]: "Did you not make this transaction?" link creates email template to invalid email address

[Yoronex]

What browsers are you seeing the problem on?

No response

Is this happening on the SudoSOS point of sale or on the SudoSOS dashboard?

Dashboard

Current behaviour

Thunderbird does somehow not like the email template behind the "Did you not make this transaction?" button in the Transaction details dialog. Due to this, I am also not allowed by Thunderbird to send the email and I have to manually choose a recipient.

Desired behaviour

No response

Steps to reproduce

1. Open SudoSOS Dashboard
2. Open a transaction by clicking on the (i).
3. Click on the "Did not make this transaction?" button in the bottom right.
4. Open the link with Thunderbird.

Other information

No response

[tomudding]

Functionality was introduced in October, however, ENV_FILE_PRODUCTION has not been updated since May so VITE_APP_TREASURER_EMAIL is not populated.

[JustSamuel]

Edit: @tomudding it has been added, its not a secret anymore, just a variable.

[tomudding]

Edit: @tomudding it has been added, its not a secret anymore, just a variable.

Sorry! However, then you should delete the old "secret" ENV_FILE_DEVELOPMENT/ENV_FILE_PRODUCTION.

[JustSamuel]

Seems to be related to git commit hash problem? It "feels" like the env file not being loaded in production.

The only difference between production and test is a "./" in the file name of the .env file.

sudosos-frontend/.github/workflows/docker.yml

Line 50 in d9e99ba

echo "${ENV_FILE}" > ./apps/${{ matrix.dir }}/.env

sudosos-frontend/.github/workflows/docker.yml

Line 57 in d9e99ba

echo "${ENV_FILE}" > apps/${{ matrix.dir }}/.env

However @tomudding does not believe that to be the issue. I'm still pro testing it, or at least changing it, such that test and prod are the same.

[tomudding]

However @tomudding does not believe that to be the issue. I'm still pro testing it, or at least changing it, such that test and prod are the same.

To elaborate; other env variables work as expected. However, I do agree with still changing it!