Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annulling decision after organ has been altered succeeds #283

Open
rinkp opened this issue Apr 28, 2023 · 2 comments
Open

Annulling decision after organ has been altered succeeds #283

rinkp opened this issue Apr 28, 2023 · 2 comments

Comments

@rinkp
Copy link
Member

rinkp commented Apr 28, 2023

Current behaviour

It is possible to annul a decision which founds an organ after the organ has been discharged

Desired behaviour

We should check if the organ has been abolished before we allow to annul the decision as this is not a valid course of action

Steps to reproduce

  1. Found an organ in meeting 1 (let's say decision 1.1.1)
  2. Abolish the organ in meeting 2
  3. Annul decision 1.1.1

Database version

c17ffb7

What operating are you seeing the problem on?

No response

What browsers are you seeing the problem on?

No response

Other information

No response

@tomudding
Copy link
Member

I assume it will be possible to annul a lot of things that already have had other changes applied to it. We can easily check this by looking for references to the original decision (when deleting decisions we just try and catch but that is of course something that should not be applied here).

@tomudding
Copy link
Member

I assume it will be possible to annul a lot of things that already have had other changes applied to it. We can easily check this by looking for references to the original decision (when deleting decisions we just try and catch but that is of course something that should not be applied here).

Ideally we do this without actually loading an entity. So we probably need to select a single scalar and setMaxResults(1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants