Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Field vgrid metadata in MAPL3 #3139

Open
tclune opened this issue Oct 31, 2024 · 0 comments
Open

Change Field vgrid metadata in MAPL3 #3139

tclune opened this issue Oct 31, 2024 · 0 comments
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring

Comments

@tclune
Copy link
Collaborator

tclune commented Oct 31, 2024

Currently in MAPL3 the following information is stored about vertical structure of a field:

  • num levels of grid (i.e., not of the field itself)
  • vloc (staggering)

The following change should be implemented:

  1. Field should store the number of levels it has. Most queries to a field want this not of the vertical grid and the existing design requires multiple accesses to info to calculate it.
  2. Surface field should not have any entry for num levels. (Using 0 could be made to work, but ...)
  3. "vloc" should be renamed "vstagger"
  4. Parameters for staggering and the strings used for I/O should be colocated.
@tclune tclune added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🛠️ Refactor This is code refactoring 📈 MAPL3 MAPL 3 Related labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring
Projects
None yet
Development

No branches or pull requests

1 participant