Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reconcile mk_GEOSldasRestarts.F90 and mk_Catch[CN]Restarts.F90 #360

Open
gmao-rreichle opened this issue Jan 28, 2021 · 0 comments
Open

reconcile mk_GEOSldasRestarts.F90 and mk_Catch[CN]Restarts.F90 #360

gmao-rreichle opened this issue Jan 28, 2021 · 0 comments
Assignees
@weiyuan-jiang
Labels
0-diff infrastructure

Comments

@gmao-rreichle
Copy link
Contributor

gmao-rreichle commented Jan 28, 2021 •
edited
Loading

@smahanam suggests moving mk_GEOSldasRestarts.F90 from the GEOSldas repository (back) into the ./mk_restarts directory in the GEOSgcm_GridComp repository, to have it alongside mk_CatchRestarts.F90 and mk_CatchCNRestarts.F90.

Rather than simply moving mk_GEOSldasRestarts.F90, I recommend that we take this opportunity to clean up code that is duplicated between mk_GEOSldasRestarts.F90 and mk_Catch[CN]Restarts.F90. Ideally, mk_GEOSldasRestarts.F90 would be replaced with a very simple program or script that uses executables from ./mk_restarts

@weiyuan-jiang offered take a first crack at this.

Note that GEOSgcm_GridComp PR#402 relocates ./mk_restarts within the GCM GridComp.

Note the remaining mkRestarts work related GCM GC PR #360 about supporting both CNCLM4.0 and CNCLM4.5. This can perhaps be addressed along this the present issue.

cc: @gmao-jkolassa @biljanaorescanin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weiyuan-jiang weiyuan-jiang

Labels
0-diff infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weiyuan-jiang @gmao-rreichle