Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Achem uses a different solar code than the rest of the model #179

Open
mathomp4 opened this issue Apr 25, 2022 · 0 comments
Open

Achem uses a different solar code than the rest of the model #179

mathomp4 opened this issue Apr 25, 2022 · 0 comments
Assignees
Labels
question Further information is requested

Comments

@mathomp4
Copy link
Member

In looking at Achem because of GEOS-ESM/GOCART#140, I noticed that Achem has its own solar zenith angle code that is not consistent with the rest of GEOS, which uses MAPL_SunGetInsolation. I know recently @dr0cloud enabled fancier orbital parameters, etc for the GEOS sun code, and the question is: should Achem use that same code so they use the same sun?

Now, perhaps Achem needs to use a different zenith angle code because the files it's trying to apply a diurnal cycle to used a different code? I'm not sure. But in the future, perhaps the files being read will have been generated by code using the MAPL sun code and this might need to be changed.

For now, I'm going to "assign" to the chemistry folks I sort of think of with Achem, but I might not know the right ones. Please re-assign to the right people.

@mathomp4 mathomp4 added the question Further information is requested label Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants