Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the mighty z-index clean up 🧼 #1620

Open
RobAndrewHurst opened this issue Oct 29, 2024 · 0 comments
Open

the mighty z-index clean up 🧼 #1620

RobAndrewHurst opened this issue Oct 29, 2024 · 0 comments
Labels
Code Issues related to the code structure and performance. CSS Changes in stylesheets RFC Request for Comment or Change.

Comments

@RobAndrewHurst
Copy link
Contributor

Description

The z-index css property is used and abused in the current codebase trying to get different elements to fit in different contexts. We can use the isolation property to correct these based on the context of where the elements are being used.

https://developer.mozilla.org/en-US/docs/Web/CSS/isolation

/* Keyword values */
isolation: auto;
isolation: isolate;

/* Global values */
isolation: inherit;
isolation: initial;
isolation: revert;
isolation: revert-layer;
isolation: unset;

We want to avoid using z-index values of 99999 as I don't know what that magic number is doing compared to 999998. It's very hard to read and extremely hard to manage different elements.

@RobAndrewHurst RobAndrewHurst added Code Issues related to the code structure and performance. RFC Request for Comment or Change. CSS Changes in stylesheets labels Oct 29, 2024
@RobAndrewHurst RobAndrewHurst changed the title CSS z-index clean up the mighty z-index clean up 🧼 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Issues related to the code structure and performance. CSS Changes in stylesheets RFC Request for Comment or Change.
Projects
None yet
Development

No branches or pull requests

1 participant