Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer and mapview changeend event methods #1559

Closed
dbauszus-glx opened this issue Oct 11, 2024 · 1 comment · Fixed by #1601
Closed

layer and mapview changeend event methods #1559

dbauszus-glx opened this issue Oct 11, 2024 · 1 comment · Fixed by #1601
Assignees
Labels
Bug A genuine bug. There must be some form of error exception to work with. Code Issues related to the code structure and performance. Documentation Adding or updating documentation. Testing Changes relating to existing or new unit tests.

Comments

@dbauszus-glx
Copy link
Member

There are multiple changeEnd events added to the mapview.Map in regards to layers loading/rendering.

The /lib/layer/changeEnd module method isn't documented at all. These methods should be reviewed and tested proper.

@dbauszus-glx dbauszus-glx added Code Issues related to the code structure and performance. Testing Changes relating to existing or new unit tests. Documentation Adding or updating documentation. labels Oct 11, 2024
@dbauszus-glx dbauszus-glx self-assigned this Oct 11, 2024
@dbauszus-glx dbauszus-glx added the Bug A genuine bug. There must be some form of error exception to work with. label Oct 23, 2024
@dbauszus-glx dbauszus-glx linked a pull request Oct 23, 2024 that will close this issue
@simon-leech
Copy link
Contributor

After creating a new location, a mapChange event should be fired to ensure that any associated dataviews on a layer are reloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with. Code Issues related to the code structure and performance. Documentation Adding or updating documentation. Testing Changes relating to existing or new unit tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants