Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler flags in audiomanager.pc.in #60

Open
kodiakz opened this issue May 12, 2022 · 1 comment
Open

compiler flags in audiomanager.pc.in #60

kodiakz opened this issue May 12, 2022 · 1 comment

Comments

@kodiakz
Copy link

kodiakz commented May 12, 2022

audiomanager.pc.in sets Cflags to include AUDIOMANAGER_CMAKE_CXX_FLAGS, which in turn brings in the -pedantic flag. This is intrusive to the user of that pkg-config, enforcing to provide own code to be compatible - and sometimes impossible if using incompatible 3rd party code.
What is the intention of including extraneous flags here? -pedantic should not be enforced in the interface.

@ghost
Copy link

ghost commented May 13, 2022

This is most likely a relict from the early days of the audiomanager. Although the AM itself claims conformity with ISO C++, it seems reasonable not strictly requiring this from users of the accompanying libraries.
So I propose removing this flag from the projects exports (both pkgconfig and cmake).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant