Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect invalid excludehop #875

Open
ahelsing opened this issue Dec 2, 2015 · 0 comments
Open

Detect invalid excludehop #875

ahelsing opened this issue Dec 2, 2015 · 0 comments

Comments

@ahelsing
Copy link
Member

ahelsing commented Dec 2, 2015

It would be nice if stitcher could detect an invalid excludehop.

Specifically:
urn:publicid:IDN+authority+interface+interfacename is valid, as is urn:publicid:IDN+authority+interface+interfacename=vlannumber. Such as urn:publicid:IDN+exogeni.net:pscvmsite+interface+PSC:ExoGeni:TenGigabitEthernet:1:ethernet or urn:publicid:IDN+exogeni.net:pscNet+interface+pscNet:Domain:vlan:18cb52fd-b2e6-43b3-9f06-ef82d954a393:vlan
or
urn:publicid:IDN+exogeni.net:pscNet+interface+pscNet:Domain:vlan:18cb52fd-b2e6-43b3-9f06-ef82d954a393:vlan=1234

However, these are malformed:
urn:publicid:IDN+exogeni.net:pscNet+interface+pscNet:Domain:vlan:18cb52fd-b2e6-43b3-9f06-ef82d954a393:vlan:vlannumber
urn:publicid:IDN+exogeni.net:pscvmsite+interface+PSC:ExoGeni:TenGigabitEthernet:1:ethernet:1234

That is, the vlan numbers to exclude are separated by an equals sign - anything else is wrong. The problem is that the difference is subtle. The rules on naming hops are rather loose. Nothing precludes ending an interface name with a number. So this is legal:
urn:publicid:IDN+exogeni.net:pscvmsite+interface+PSC:ExoGeni:TenGigabitEthernet:1:ethernet:3
or
urn:publicid:IDN+exogeni.net:pscvmsite+interface+PSC:ExoGeni:TenGigabitEthernet:1:ethernet:3-5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant