Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of Residuals subclasses #97

Open
g-weatherill opened this issue Oct 16, 2018 · 0 comments
Open

Refactor of Residuals subclasses #97

g-weatherill opened this issue Oct 16, 2018 · 0 comments

Comments

@g-weatherill
Copy link
Collaborator

Currently the comparison of GMPEs to data is undertaken in the smtk.residuals.gmpe_residuals.Residuals class. The various tools for analysis the model fit (Likelihood, LLH, EDR, MultivariateLLH) all subclass the Residuals object, adding on specific functions when needed. This was intended when the anticipated use case was to look at exploring the results from a single tool. The downside, however, is that if the user wishes to apply several metrics then they need to instantiate each class, and thus re-calculate the residuals, which is extremely time consuming. As this latter workflow is becoming more common there is no good argument for keeping the tools as separate classes. Instead a refactor is proposed to move the functions as methods of the core residuals class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant