Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android-extension generated imports as star #16

Open
StefMa opened this issue Apr 16, 2018 · 2 comments
Open

Add android-extension generated imports as star #16

StefMa opened this issue Apr 16, 2018 · 2 comments

Comments

@StefMa
Copy link
Contributor

StefMa commented Apr 16, 2018

If we use the kotlin android-extension we have something like that in our imports:

import kotlinx.android.synthetic.main.fragment_settings.app_info_text
import kotlinx.android.synthetic.main.fragment_settings.fingerprint_switch
import kotlinx.android.synthetic.main.fragment_settings.global_access_right
import kotlinx.android.synthetic.main.fragment_settings.global_access_right_switch
import kotlinx.android.synthetic.main.fragment_settings.icon_global_access_right_help
import kotlinx.android.synthetic.main.fragment_settings.login_data
import kotlinx.android.synthetic.main.fragment_settings.login_data_header
import kotlinx.android.synthetic.main.fragment_settings.password_edit
import kotlinx.android.synthetic.main.fragment_settings.security_settings_section
import kotlinx.android.synthetic.main.fragment_settings.set_up_settings_security
import kotlinx.android.synthetic.main.fragment_settings.set_up_super_pin
import kotlinx.android.synthetic.main.fragment_settings.settings_content
import kotlinx.android.synthetic.main.fragment_settings.settings_security_text_layout
import kotlinx.android.synthetic.main.fragment_settings.settings_super_pin_text_layout
import kotlinx.android.synthetic.main.fragment_settings.start_tutorial
import kotlinx.android.synthetic.main.fragment_settings.tracking_layout
import kotlinx.android.synthetic.main.fragment_settings.tracking_switch
import kotlinx.android.synthetic.main.fragment_settings.tutorial_layout
import kotlinx.android.synthetic.main.fragment_settings.username_edit

From my point of view that can be easly added as star imports. There is no need to use them as a single import...

@passsy
Copy link
Contributor

passsy commented Apr 17, 2018

If you have

import kotlinx.android.synthetic.main.fragment_settings.*
import kotlinx.android.synthetic.main.fragment_login.*

How do you know where username_edit comes from?

Would the star import improve autocompletion?

@StefMa
Copy link
Contributor Author

StefMa commented Apr 17, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants