Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Remove commented out generalQuestionResponses on GeneralQuestion type #12243

Closed
1 task
mnigh opened this issue Dec 10, 2024 · 0 comments · Fixed by #12377
Closed
1 task

♻️ Remove commented out generalQuestionResponses on GeneralQuestion type #12243

mnigh opened this issue Dec 10, 2024 · 0 comments · Fixed by #12377
Assignees
@mnigh
Labels
debt Refactor or improve existing code.

Comments

@mnigh
Copy link
Contributor

mnigh commented Dec 10, 2024

♻️ Debt

Remove commented out line for generalQuestionResponses on GeneralQuestion type.

🕵️ Details

gc-digital-talent/api/graphql/schema.graphql

Line 236 in 4aae3b4

# generalQuestionResponses: [GeneralQuestionResponse] @hasMany # TODO: uncomment this and add sensible permission check

🙋‍♀️ Proposed Solution

Remove

# generalQuestionResponses: [GeneralQuestionResponse] @hasMany # TODO: uncomment this and add sensible permission check

✅ Acceptance Criteria

  • # generalQuestionResponses: [GeneralQuestionResponse] @hasMany # TODO: uncomment this and add sensible permission does not appear in codebase
@mnigh mnigh added the debt Refactor or improve existing code. label Dec 10, 2024
@mnigh mnigh moved this to 🏭 Ready for Estimate in GC Digital Talent Dec 10, 2024
@mnigh mnigh self-assigned this Dec 24, 2024
@mnigh mnigh moved this from 🏭 Ready for Estimate to 🏗 In progress in GC Digital Talent Dec 24, 2024
@mnigh mnigh mentioned this issue Dec 24, 2024
Merged
@mnigh mnigh moved this from 🏗 In progress to 👀 In review in GC Digital Talent Dec 24, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in GC Digital Talent Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnigh mnigh

Labels
debt Refactor or improve existing code.
Projects
GC Digital Talent
Status: ✅ Done
Milestone
No milestone
1 participant
@mnigh