Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Talent mobility options form #12011

Open
1 task done
esizer opened this issue Nov 19, 2024 · 2 comments
Open
1 task done

✨ Talent mobility options form #12011

esizer opened this issue Nov 19, 2024 · 2 comments
Labels
feature New feature or request.

Comments

@esizer
Copy link
Member

esizer commented Nov 19, 2024

✨ Feature

Inline form for editing a users talent management options, to be placed on the "Career planning" page.

🕵️ Details

This will be a new inline form using the mutations/queries defined in the backend data for Career planning ticket.

The section subheading includes a status icon, showing error if any fields are empty, and success if all fields are filled.

🎨 Design

Design link, @JoshBeveridge

📸 Screenshot

Please see figma

🙋‍♀️ Proposed Implementation

Create a new component under ~/pages/Users/CareerPlanning/components that uses the ToggleSection to include an inline form.

If the page stub is completed, include the component on the page under the second section as the first item.

🌎 Localization

✅ Acceptance Criteria

  • Inline editing form component created
    • Radio buttons are required, checkboxes or checkbox groups are not
    • "Missing information" labels appear, the the overall status is incomplete, if any of the fields are null. Empty arrays are okay.
    • In the view mode, checkboxes are represented along with a green/grey icon, radio buttons are not.
  • Connected to API (queries, mutations)
  • If page exists, added to page in correct location
    • set the status of the Table of Contents entries.
  • Design review by @JoshBeveridge
  • Language review by @NienkeBr

🛑 Blockers

Blocked By

Preview Give feedback
  1. feature
    esizer
@esizer esizer added the feature New feature or request. label Nov 19, 2024
Copy link

github-actions bot commented Nov 19, 2024

Status: Ready to merge ✔️

Issues blocking this PR:


This comment was automatically written by the Blocking Issues bot, and this PR will be monitored for further progress.

@tristan-orourke tristan-orourke added this to the Employee Profile milestone Dec 4, 2024
@gobyrne gobyrne changed the title ✨ Talent management options form ✨ Talent mobility options form Dec 12, 2024
@tristan-orourke tristan-orourke moved this to 🏭 Ready for Estimate in GC Digital Talent Dec 12, 2024
@github-actions github-actions bot added the blocked: dependencies Blocked by other issues. label Dec 16, 2024
@tristan-orourke
Copy link
Member

Our current inline form component doesn't exactly match the design in figma. Don't worry about it, use the current component, we will update the component in its own ticket. We will update it everywhere consistently.

@tristan-orourke tristan-orourke moved this from 🏭 Ready for Estimate to 📋 Ready for Dev in GC Digital Talent Dec 19, 2024
@github-actions github-actions bot removed the blocked: dependencies Blocked by other issues. label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request.
Projects
Status: 📋 Ready for Dev
Development

No branches or pull requests

2 participants