Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate UHS Web back to the docker #402

Open
dcoric opened this issue Jan 21, 2025 · 3 comments
Open

Migrate UHS Web back to the docker #402

dcoric opened this issue Jan 21, 2025 · 3 comments
Assignees

Comments

@dcoric
Copy link
Collaborator

dcoric commented Jan 21, 2025

As we no longer have to pass parameters to the web build (UHS and YK) we can build the project in the docker to reduce tooling overhead in the make configuration

@dcoric dcoric self-assigned this Jan 21, 2025
@dcoric
Copy link
Collaborator Author

dcoric commented Jan 23, 2025

The best solution is to use build steps 2x once for UHS, the second one for YK Web. The only part that has to be tested is copying data from build steps into target container

@dcoric
Copy link
Collaborator Author

dcoric commented Jan 24, 2025

Web build and YK Web builds are moved to docker.
make web-build command is still there and can be used to test web locally with make run
I have removed node from install-tools part, but added as a dependency for web-build and will be triggered only then.

@dcoric
Copy link
Collaborator Author

dcoric commented Jan 27, 2025

Optimized build by removing additional intermediate build step, and removed package.json dependency for yunikorn-web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant