Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rdflib dependent code to own library #417

Open
mpsonntag opened this issue Dec 6, 2021 · 8 comments
Open

Move rdflib dependent code to own library #417

mpsonntag opened this issue Dec 6, 2021 · 8 comments

Comments

@mpsonntag
Copy link
Contributor

The rdflib library is required for conversion of odml to its RDF specific format. Since this library has caused multiple issues in the past and is still causing issues to this date it might be worth looking into moving RDF dependent code from the odml core library into a dedicated sub-library.

@penguinpee
Copy link
Contributor

Hi. May I ask what the plans are with regards to rdflib? Version 6.2.0 has landed in Fedora rawhide recently, breaking the build of odml. I noticed odml has the rdflib version pinned to 5.0.0. That would require a compat rdflib5 package in Fedora to satisfy odml's dependencies.

Before we embark on that endeavor I wanted to check with upstream (you) on plans for making odml work with rdflib >= 6.0.0.

@mpsonntag
Copy link
Contributor Author

Hi @penguinpee, thank you for the comment! This issue has been on my todo list for quite a while now, but unfortunately I cannot say, when I will get around to addressing it as of yet.
My plan would be to first fix the build with the latest RDFlib version available. This will probably require a small change in the odml RDF definition regarding list items of which the handling I think has changed in one of the newer RDFlib version.
Once that is done I would like to keep RDF in the odml library, but make it an optional installable. Maybe these infos already help a bit in making a decision.

@penguinpee
Copy link
Contributor

My plan would be to first fix the build with the latest RDFlib version available. This will probably require a small change in the odml RDF definition

Excellent. This would also be the easiest way forward for us. Small change sounds good. Would you have an estimate when this small change can be expected? Not trying to push, just gathering info for relaying back to the group.

Thanks for the quick response.

@mpsonntag
Copy link
Contributor Author

Would you have an estimate when this small change can be expected?

I would like to fix it within the next 2 month, but I am a bit swamped at the moment so please don't hold it against me if it takes a smidge longer.

@penguinpee
Copy link
Contributor

A gentle nudge: not pushing, just wondering if there is any news, any update.

@mpsonntag
Copy link
Contributor Author

@penguinpee: I think I managed to upgrade to the usage of rdflib >= 6.0.0, but still need to clear some changes with the other core devs and run some tests in the ecosystem before putting up a new PyPI version.

@penguinpee
Copy link
Contributor

Thanks a lot. I'll wait for the updated PyPI package, which should trigger some notification by release monitoring on our end.

@mpsonntag
Copy link
Contributor Author

A new release (1.5.3) has been uploaded to PyPI that supports rdflib v6+ by default. There should be no changes in behavior. Users that require Python <=3.6 still have to rely on rdflib v5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants