Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Performance issues by just doing nothing #140

Open
Torathion opened this issue Oct 21, 2024 · 3 comments
Open

[Bug]: Performance issues by just doing nothing #140

Torathion opened this issue Oct 21, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Torathion
Copy link

Mod Loader (Required)

Fabric

Minecraft Version(s) (Required)

1.21.1

Mod Version(s) (Required)

21.1.18

Other Mods Involved (Required)

Yes

Notes (Required)

I'm testing out a minimal modpack and wanted to install visual workbench, but just having that and this library made my performance (that's already low thanks to my low end pc) worse. I don't know why, but it keeps doing stuff in the background.

Spark logs:
Lithium + PuzzlesLib: https://spark.lucko.me/unxojQ2axc
Lithium alone: https://spark.lucko.me/Yo4KIAyHfZ
Without both (because I realized I don't need Lithium): https://spark.lucko.me/SW9UWUFHi7
PuzzlesLib alone: https://spark.lucko.me/8PEeIZ3Jce

Since I'm still new to all of this, I can't provide much information to why it's acting up on my system.

latest.log (Required)

https://mclo.gs/0QFva4y

@Torathion Torathion added the bug Something isn't working label Oct 21, 2024
@Fuzss
Copy link
Owner

Fuzss commented Oct 22, 2024

That's a false flag. Puzzles Lib wraps a vanilla method call and is therefore blamed for the overhead of the vanilla method.
Will adjust the implementation so this is no longer the case.

@Torathion
Copy link
Author

It's not really a false flag. I can attest with my low end PC that this actually lowers my FPS by 3 - 5 and I get occasionally micro stutters. It's even higher in combination with other mods that I had performance issues with, like Lithium completely crippled my performance from constant 40 -> 15.

@Fuzss
Copy link
Owner

Fuzss commented Oct 22, 2024

Feel free to join our Discord for help with improving performance. Definitely check the FAQ channel.
https://lunapixel.studio/discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants