You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
validateCapability in ForgeCapabilityKey uses a fair amount of resources on the main thread for string formatting, regardless of whether the capability is null or not. Changing the string to a constant or using the Supplier<String> overload should fix the issue. I see that the same paradigm is used in a few other places throughout the repo, but I haven't seen issues with any of those.
This seems to significantly hurt the performance of Thin Air, specifically.
The text was updated successfully, but these errors were encountered:
Mod Loader (Optional)
Forge
Minecraft Version(s) (Optional)
1.19.2
Mod Version(s) (Optional)
4.4.3
Suggestion (Required)
validateCapability
inForgeCapabilityKey
uses a fair amount of resources on the main thread for string formatting, regardless of whether the capability is null or not. Changing the string to a constant or using theSupplier<String>
overload should fix the issue. I see that the same paradigm is used in a few other places throughout the repo, but I haven't seen issues with any of those.This seems to significantly hurt the performance of Thin Air, specifically.
The text was updated successfully, but these errors were encountered: