Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the SystemConfigManager #16

Open
abacef opened this issue Aug 9, 2019 · 0 comments
Open

Get rid of the SystemConfigManager #16

abacef opened this issue Aug 9, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@abacef
Copy link
Collaborator

abacef commented Aug 9, 2019

Is your feature request related to a problem? Please describe.
It is hard to follow the code sometimes because systemConfigManager can be called from anywhere because it is global

Describe the solution you'd like
Remove the SystemConfigManager and maybe refactor the codebase to a version of MVC (because there are many). I am not sure what design pattern this currently follows. It almost follows MVC, but the model package actually specifies domain objects, and the Application package is not really the controller, it is more like a model, except the UIController which is the controller. The UI package is pretty good though.

Describe alternatives you've considered
I attempted to remove the SystemConfigManager and pass each application reference from the members of the SCM into the necessary classes via creating them in MainFrame. This is in the branch no-system-config-manager if you want to take a look at it. Everything functions like it did before except more weird things happen with the UI text sizing, but that was already broken.

Additional context
None

@abacef abacef added the enhancement New feature or request label Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant