Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLMModel does not support tool calling #701

Open
jamesbraza opened this issue Nov 18, 2024 · 0 comments
Open

LLMModel does not support tool calling #701

jamesbraza opened this issue Nov 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jamesbraza
Copy link
Collaborator

It would be nice if LLMModel directly supported tool calling.

That way, we wouldn't need to shim to aviary.ToolSelector like we do here:

paper-qa/paperqa/llms.py

Lines 757 to 764 in 6fda922

async def select_tool(
self, *selection_args, **selection_kwargs
) -> ToolRequestMessage:
"""Shim to aviary.core.ToolSelector that supports tool schemae."""
tool_selector = ToolSelector(
model_name=self.name, acompletion=self.router.acompletion
)
return await tool_selector(*selection_args, **selection_kwargs)

@jamesbraza jamesbraza added the enhancement New feature or request label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant