Disk space usage is double-counted for reseller account with nested end-users

[Dolphyn5]

Describe the bug
Disk space is double-counted for reseller account with nested end-users.

To Reproduce

1. Set up a reseller account and hosting space configured so that end-user spaces are inside the reseller's folder. I don't remember where to find this setting in SolidCP, but in the database [dbo].[PackageSettings] there is a row with SettingsName='ChildSpacesFolder', PropertyName='ChildSpacesFolder', PropertyValue=''.
2. Set up an end-user account with hosting space which will be inside the reseller's folder.
3. Add a few large files into the end-user's hosting space so that there is some disk usage to count. (In my case the files are within websites, but I don't think it matters.)
4. Make sure the system is configured to collect disk space, and wait for the disk space task to run.
5. Now view the disk space for the reseller's package and end-user's package. That is, Default.aspx?pid=DiskspaceReport&SpaceID=??&ctl=edit&mid=??
6. Observe that the reseller's "Files" report shows about twice the disk usage shown in the end-user's "Files" report.

Expected behavior
I would expect the reseller's "Files" report to show the same disk usage that is shown in the end-user's "Files" report, and it should match the actual usage.

SolidCP Info

• SolidCP Version: 1.4.8

Additional context
I previously reported this same issue back in 2017. I think it was fixed in the past, but if so the issue has returned. Thanks!

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.