Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong types #14

Open
marc2332 opened this issue May 21, 2022 · 1 comment · May be fixed by #18
Open

Wrong types #14

marc2332 opened this issue May 21, 2022 · 1 comment · May be fixed by #18

Comments

@marc2332
Copy link
Contributor

marc2332 commented May 21, 2022 •
edited
Loading

I just realized some of the TypeScript types I implemented in the last PR are not accurate at all:

  • LanguageServerClientOptions requires a documentUri, which is not necessary for the client
  • And languageServerWithTransport doesn't actually always need a transport if client is passed

I will fix this asap
@hjr265
Copy link
Member

hjr265 commented May 23, 2022

@marc2332 Thank you for revisiting this. Sure, a PR would be appreciated.

This was referenced Jul 2, 2022
Merged
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix and improved TypeScript types marc2332/codemirror-languageserver
2 participants
@hjr265 @marc2332