"Bug" Report: Small harmless typos I found randomly

[Starexify]

Issue Checklist

• I have read the pinned Issues Guide
• I have checked the Issues/Discussions pages to see if my issue has already been reported
• I have properly named my issue

Platform

Windows

Version

0.5.3

Description (include any images, videos, errors, or crash logs)

Not a bug but I found some syntax errors:

1. ;'s at the end of functions/conditions
   

   Funkin/source/funkin/play/PlayState.hx

   Line 1141 in df142a9

   };

   
   

   Funkin/source/funkin/play/PlayState.hx

   Line 1531 in df142a9

   };

   
   

   Funkin/source/funkin/ui/freeplay/FreeplayState.hx

   Line 2448 in df142a9

   };

   
   

   Funkin/source/funkin/ui/charSelect/CharSelectPlayer.hx

   Line 52 in df142a9

   };

   
   

   Funkin/source/funkin/ui/charSelect/CharSelectPlayer.hx

   Lines 83 to 89 in df142a9

   	public function onScriptEvent(event:ScriptEvent):Void {};
   	public function onCreate(event:ScriptEvent):Void {};
   	public function onDestroy(event:ScriptEvent):Void {};
   	public function onUpdate(event:UpdateScriptEvent):Void {};

   
   

   Funkin/source/funkin/ui/charSelect/CharSelectGF.hx

   Line 92 in df142a9

   };

   
   

   Funkin/source/funkin/ui/charSelect/CharSelectGF.hx

   Lines 208 to 214 in df142a9

   	public function onScriptEvent(event:ScriptEvent):Void {};
   	public function onCreate(event:ScriptEvent):Void {};
   	public function onDestroy(event:ScriptEvent):Void {};
   	public function onUpdate(event:UpdateScriptEvent):Void {};

   
   

   Funkin/source/funkin/play/song/Song.hx

   Lines 634 to 674 in df142a9

   	public function onPause(event:PauseScriptEvent):Void {};
   	public function onResume(event:ScriptEvent):Void {};
   	public function onSongLoaded(event:SongLoadScriptEvent):Void {};
   	public function onSongStart(event:ScriptEvent):Void {};
   	public function onSongEnd(event:ScriptEvent):Void {};
   	public function onGameOver(event:ScriptEvent):Void {};
   	public function onSongRetry(event:ScriptEvent):Void {};
   	public function onNoteIncoming(event:NoteScriptEvent) {}
   	public function onNoteHit(event:HitNoteScriptEvent) {}
   	public function onNoteMiss(event:NoteScriptEvent):Void {};
   	public function onNoteGhostMiss(event:GhostMissNoteScriptEvent):Void {};
   	public function onSongEvent(event:SongEventScriptEvent):Void {};
   	public function onStepHit(event:SongTimeScriptEvent):Void {};
   	public function onBeatHit(event:SongTimeScriptEvent):Void {};
   	public function onCountdownStart(event:CountdownScriptEvent):Void {};
   	public function onCountdownStep(event:CountdownScriptEvent):Void {};
   	public function onCountdownEnd(event:CountdownScriptEvent):Void {};
   	public function onScriptEvent(event:ScriptEvent):Void {};
   	public function onCreate(event:ScriptEvent):Void {};
   	public function onDestroy(event:ScriptEvent):Void {};
   	public function onUpdate(event:UpdateScriptEvent):Void {};

2. Duplicate Imports:
   FunkinSound:

   Funkin/source/funkin/ui/options/OptionsState.hx

   Lines 10 to 15 in df142a9

   	import funkin.audio.FunkinSound;
   	import funkin.ui.mainmenu.MainMenuState;
   	import funkin.ui.MusicBeatState;
   	import funkin.graphics.shaders.HSVShader;
   	import funkin.util.WindowUtil;
   	import funkin.audio.FunkinSound;

3. , at the end of a list/array etc
   

   Funkin/source/funkin/play/PlayState.hx

   Line 2703 in df142a9

   targetSongId: currentSong.id,

[AbnormalPoof]

These are not syntax errors. The game wouldn't compile if they were.

[Hundrec]

What do you mean by syntax errors? Are the semicolons not necessary?

[Lasercar]

What do you mean by syntax errors? Are the semicolons not necessary?

https://en.wikipedia.org/wiki/Syntax_error

It's only a syntax error when it'd result in the code not being able to compile. These are all harmless typos.
The duplicate import in the options state could be fixed though.

[Hundrec]

I know what a syntax error is. I just don't think these are syntax errors for the reason AbnormalPoof stated.

[Hundrec]

As a non-coder, I still don't understand how these are typos. Don't lines of code usually end with semicolons?
The only reason I'd think to remove these would be if they differed from the general codestyle.

[Starexify]

As a non-coder, I still don't understand how these are typos. Don't lines of code usually end with semicolons?
The only reason I'd think to remove these would be if they differed from the general codestyle.

So, normally conditions and functions don't have ; at the end, I think haxe doesn't take those in consideration when compiling (not sure, + could be the same with the public statement in methods but wont complain in the fnf code tho it would remove some size from the src)

[Hundrec]

Thanks for clarifying!
If you can compile the game without these semicolons, then you should create a PR for this and the duplicate import.

[Starexify]

Thanks for clarifying! If you can compile the game without these semicolons, then you should create a PR for this and the duplicate import.

Sorry for this but how do I create a PR with these fixes 🤔

[Hundrec]

You should create your own fork of Funkin, edit the semicolons and import out of the file, commit the changes, then click on the "Create/open pull request" button that appears on the pull requests page.

[Starexify]

Alright thanks I opened a PR #4092 and will update if I found anything else through the files 👍