Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support doc comments on submodule (mod) items #6879 #6925

Open
ironcev opened this issue Feb 12, 2025 · 0 comments
Open

Support doc comments on submodule (mod) items #6879 #6925

ironcev opened this issue Feb 12, 2025 · 0 comments
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: parser Everything to do with the parser compiler General compiler. Should eventually become more specific as the issue is triaged P: low team:compiler Compiler Team

Comments

@ironcev
Copy link
Member

ironcev commented Feb 12, 2025

Currently, all attributes are forbidden on module items, including doc comments (///). E.g., the following is not allowed:

/// This is an outer doc comment for `some_module`.
mod some_module;

This is unnecessary too restrictive and it breaks the semantic of having both inner and outer attributes and the possibility to combine them. In Rust, if both outer and inner doc comments are provided for a module they get combined in the doc for that modules, following the semantic of combining inner and outer attributes.

@ironcev ironcev added compiler General compiler. Should eventually become more specific as the issue is triaged P: low compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: parser Everything to do with the parser team:compiler Compiler Team labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: parser Everything to do with the parser compiler General compiler. Should eventually become more specific as the issue is triaged P: low team:compiler Compiler Team
Projects
None yet
Development

No branches or pull requests

1 participant