Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor unify_check check_inner. #6845

Open
esdrubal opened this issue Jan 20, 2025 · 0 comments
Open

Refactor unify_check check_inner. #6845

esdrubal opened this issue Jan 20, 2025 · 0 comments
Assignees
@esdrubal
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen

Comments

@esdrubal
Copy link
Contributor

esdrubal commented Jan 20, 2025 •
edited
Loading

unify_checker check_inner method is becoming quite large we should split it up into multiple methods.

          Nit: We really should refactor this method. It's extremely long, and it's hard to follow what's going on when the entire method doesn't fit on the screen.

Originally posted by @jjcnn in #6827 (comment)
@esdrubal esdrubal self-assigned this Jan 20, 2025
@esdrubal esdrubal added the compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen label Jan 20, 2025
@esdrubal esdrubal changed the title Refactor unify_check. Refactor unify_check check_inner. Jan 20, 2025
@esdrubal esdrubal mentioned this issue Jan 20, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esdrubal esdrubal

Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@esdrubal