Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: gracefully handle unknown transaction variants #1499

Open
wants to merge 11 commits into
base: 0.67.0-dev
Choose a base branch
from
Open

feat!: gracefully handle unknown transaction variants #1499

wants to merge 11 commits into from

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Sep 2, 2024 •
edited
Loading

Closes #1477

Release notes

In this release, we:
will be added later

Summary

fuels-rs is using fuel-core-client to communicate with the node.

fuel-core-client:

  • added a new TransactoinType enum with an Unknown variant to fuel-core-client.
  • added Unknown variants to ConsensusParameters and all of its fields. cynic will fallback to this variant.

fuel-core PR: FuelLabs/fuel-core#2154

Checklist:

  • transaction: fuel-core-client

    • add new TransactionType with the Unknown variant in fuel-core-client
    • refactor fuels-rs

  • coin-type: fuels-rs

    • fuel-core-client already has an Unknown variant - refactor fuels-rs

  • consensus-parameters: fuel-core-client

    • add Unknown variants to all the version enums
    • refactor code

  • block and headers: fuel-core-client

    • add Unknown variants to all the version enums
    • refactor code

  • opcodes - INVESTIGATE

Breaking Changes

  • added Unknown variant to TransactionType and CoinType

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@hal3e hal3e added the breaking Introduces or requires breaking changes label Sep 2, 2024
@hal3e hal3e self-assigned this Sep 2, 2024
@hal3e hal3e changed the title Hal3e/unknown variants feat!: gracefully handle unknown transaction variants Sep 2, 2024
@digorithm
Copy link
Member

@hal3e, can you please sync the branch with master and then change the base branch from master to 0.67.0-dev?

@hal3e hal3e changed the base branch from master to 0.67.0-dev September 8, 2024 04:00
@hal3e hal3e marked this pull request as ready for review September 20, 2024 10:30
@hal3e hal3e added the blocked label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne Br1ght0ne is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@hal3e hal3e

Labels
blocked breaking Introduces or requires breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle unknown transaction variants gracefully (consensus params, tx types, block headers)
2 participants
@hal3e @digorithm