Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use client.submit_and_await_commit in Provider #1128

Closed
segfault-magnet opened this issue Sep 11, 2023 · 2 comments
Closed

Use client.submit_and_await_commit in Provider #1128

segfault-magnet opened this issue Sep 11, 2023 · 2 comments
Assignees
@iqdecay
Labels
P2 Low priority tech-debt Improves code quality or safety

Comments

@segfault-magnet
Copy link
Contributor

Currently, we have our own send_transaction_and_await where we call submit and then await_transaction_commit.

We can just delegate to submit_and_await_commit instead.

Some refactoring is needed as we do some checks before submitting a tx.
@segfault-magnet segfault-magnet added tech-debt Improves code quality or safety P2 Low priority labels Sep 11, 2023
@iqdecay
Copy link
Contributor

iqdecay commented Nov 20, 2023 •
edited
Loading

Solved normally by #1187

@iqdecay iqdecay mentioned this issue Nov 20, 2023
Merged
@iqdecay iqdecay self-assigned this Nov 24, 2023
@iqdecay
Copy link
Contributor

iqdecay commented Nov 24, 2023

Closing in favor of #1188.

@iqdecay iqdecay closed this as completed Nov 24, 2023
iqdecay added a commit that referenced this issue Jan 8, 2024
@iqdecay @MujkicA @hal3e
refactor!: use submit_and_await_commit API (#1187)
638a548 
Closes #1180,  #1128.
This PR uses the correct API for sending a transaction and ensuring that
we wait for the commit of the transaction before returning.
This is needed because otherwise there might be a disconnect between
submitting the transaction and awaiting for its commit, if it is done
using the two separate APIs as before.

BREAKING CHANGE: 
- `send_transaction_and_await_commit` function now returns a `TxStatus`
instead of `TxId`.

---------

Co-authored-by: MujkicA <[email protected]>
Co-authored-by: hal3e <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iqdecay iqdecay

Labels
P2 Low priority tech-debt Improves code quality or safety
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iqdecay @segfault-magnet