Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassEval 5 improper assertion in tests #13

Open
doomspec opened this issue Jul 5, 2024 · 0 comments
Open

ClassEval 5 improper assertion in tests #13

doomspec opened this issue Jul 5, 2024 · 0 comments

Comments

@doomspec
Copy link

doomspec commented Jul 5, 2024

def test_interpret_6(self):
    context = AutomaticGuitarSimulator(" ")
    play_list = context.interpret()
    self.assertEqual(play_list, [{'Chord': '', 'Tune': ''}, {'Chord': '', 'Tune': ''}]) # better to remove this test
def test_interpret_9(self):
    context = AutomaticGuitarSimulator("")
    play_list = context.interpret()
    self.assertIsNone(play_list) # better to be []

These behaviours are not described in the function docstring.

Han-tj added a commit that referenced this issue Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant