Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12.2] End Dimension "Stalling/Freezing/Crash?" #160

Closed
aking4125 opened this issue Nov 12, 2023 · 5 comments
Closed

[1.12.2] End Dimension "Stalling/Freezing/Crash?" #160

aking4125 opened this issue Nov 12, 2023 · 5 comments

Comments

@aking4125
Copy link

Hello,

Upon exploring The End. The server stalls with the following stall report created by Sampler:

stall-2023-11-07_19.01.37-6.txt

Disabling the affected mobs allows the players to explore the end without the server "Hanging". Disabling this mod out right and the hangs stop entirely.

Any ideas?

@Ski-z
Copy link

Ski-z commented Nov 26, 2023

The issue is in B:"Slime blocks bounce off sides"=true in the Quark config, try disabling that!

This issue was driving me crazy, until Handeril in the 1.12.2 Modding Coalition discord helped me narrow it down.

@Handeril
Copy link

Handeril commented Nov 26, 2023

For some reason, this tweak in Quark may be the issue:
https://github.com/VazkiiMods/Quark/blob/1.12/src/main/java/vazkii/quark/tweaks/block/BlockSpringySlime.java

As the stall starts with:
at vazkii.quark.tweaks.feature.SpringySlime.applyCollision(SpringySlime.java:146)
at vazkii.quark.tweaks.feature.SpringySlime.applyForAxis(SpringySlime.java:141)
at vazkii.quark.tweaks.feature.SpringySlime.onEntityCollision(SpringySlime.java:103)
at vazkii.quark.base.asm.ASMHooks.applyCollisionLogic(ASMHooks.java:210)

Which then points to Fish's Undead rising with:
at com.Fishmod.mod_LavaCow.entities.flying.EntityFlyingMob.func_191986_a(EntityFlyingMob.java:293)

@Handeril
Copy link

Handeril commented Nov 26, 2023

The potential conflict is in the AI of EntityFlyingMob, starting at Line 293, which comes before:

this.parentEntity.getMoveHelper().setMoveTo(d0, d1, d2, 1.0D);

in this task:

    {
        Random random = this.parentEntity.getRNG();

        double d0 = this.parentEntity.posX + (double)((random.nextFloat() * 2.0F - 1.0F) * 16.0F);
        double d1 = this.parentEntity.posY + (double)((random.nextFloat() * 2.0F - 1.0F) * 16.0F);
        double d2 = this.parentEntity.posZ + (double)((random.nextFloat() * 2.0F - 1.0F) * 16.0F);
        
        if(this.parentEntity.isWet())
        	d1 = SpawnUtil.getHeight(this.parentEntity).getY() + 3.0D;
        else if(Modconfig.FlyingHeight_limit != 0 && (double)Modconfig.FlyingHeight_limit < d1)
        	d1 = (double)(SpawnUtil.getHeight(this.parentEntity).getY() + Modconfig.FlyingHeight_limit);
        
        this.parentEntity.getMoveHelper().setMoveTo(d0, d1, d2, 1.0D);
    }

https://github.com/FuGu0416/Fishs_Undead_Rising/blob/master/Forge1.12.2/src/main/java/com/Fishmod/mod_LavaCow/entities/flying/EntityFlyingMob.java

@aking4125
Copy link
Author

The issue is in B:"Slime blocks bounce off sides"=true in the Quark config, try disabling that!

This issue was driving me crazy, until Handeril in the 1.12.2 Modding Coalition discord helped me narrow it down.

Another solution was to disable Quark compatibility. But I can also try that.

@FuGu0416
Copy link
Owner

Should be fixed in #162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants