Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests more impervious to changes #197

Open
lunakv opened this issue Sep 7, 2022 · 2 comments
Open

Make tests more impervious to changes #197

lunakv opened this issue Sep 7, 2022 · 2 comments

Comments

@lunakv
Copy link
Contributor

lunakv commented Sep 7, 2022

Right now, the tests are breaking (again) because a new subtype was added and it's not included in our test data. Given how often this tends to happen, it would be nice to figure out a way to set up the tests in a way that doesn't break them every set release.

Some ideas on possible approaches to this:

  • Generate our own in-repo set of test data and test against that instead of the live APIs.
  • Somehow load the test data live from the APIs instead of hard coding them into code
  • Try to limit tests to rules/cards that won't change often and just suck it up when they do.
@lunakv
Copy link
Contributor Author

lunakv commented Feb 7, 2024

(An example I stumbled upon just now that illustrates why this is relevant:)
image

@Fryyyyy
Copy link
Owner

Fryyyyy commented Feb 7, 2024

How about we just make the rule number a regex (\d+\.\d+ or something) and just make sure it work without caring specifically what number it ends up being

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants