Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Translations #133

Open
Flamifly opened this issue Dec 16, 2024 · 46 comments
Open

Additional Translations #133

Flamifly opened this issue Dec 16, 2024 · 46 comments

Comments

@Flamifly
Copy link
Contributor

Fixed some wrong terms for the Translations and added missing once
https://github.com/Flamifly/EasePass/tree/translations

@Flamifly
Copy link
Contributor Author

I saw you changed the way PasswordSafetyChart.xaml will be translated there is a wrong term
PW_SafetyChart_Short_LowerCase
should be
PW_SafetyChart_Short_LowerCaseLetters

@FrozenAssassine
Copy link
Owner

Oh wait @finn-freitag changed the way the PasswordSafetyChart handles translations, so now all translations are handled in the xaml file directly. I really think this is the better approach. I hope this does not break your changes too much. I will merge this now and I hope everything works fine with emerging on your end then.

@Flamifly
Copy link
Contributor Author

For the PasswordSafetyChart.xaml it is hard to have the right Translations because of the prefixes
There is one Translations in German which makes no sense with that logic
image
image

@Flamifly
Copy link
Contributor Author

All good there was just some wrong terms at this point

@FrozenAssassine
Copy link
Owner

FrozenAssassine commented Dec 16, 2024

Yeah, this makes sense, I left the password safety chart a bit untouched in the way of translations due to those weird things that happen when translating to German. But I think you are on the right track there. Do you have a better approach to reworking this, would be awesome.
Also, @finn-freitag and I, won't touch the translations anymore, to prevent merge issues with your code😄.
Oh @finn-freitag already merged the code to move the translations, would you double check that you are up to date in the passwordsafetychart.xaml and .xaml.cs file? Sorry, I can also revert if you want?

@Flamifly
Copy link
Contributor Author

I will change my stuff don't worry

@Flamifly
Copy link
Contributor Author

https://github.com/Flamifly/EasePass/tree/translation2
there will be the translations
Not done yet

@Flamifly
Copy link
Contributor Author

should be finished

@Flamifly
Copy link
Contributor Author

#133 (comment)
I will have a look tomorrow on that

@finn-freitag
Copy link
Collaborator

Thank you very much, we really appreciate your work. @FrozenAssassine will merge that later.

@Flamifly
Copy link
Contributor Author

Your welcome 😄
I am gone for today see ya

@Flamifly
Copy link
Contributor Author

@FrozenAssassine @finn-freitag is there a reason that you concat the translations?
image

I would just do one translation for each prefix and not 3 different for each prefix. Is there anything that will be conflicted by that?

@FrozenAssassine
Copy link
Owner

I don't think there was a reason for that, at that time @finn-freitag did not properly know how to handle those translations and so we made a quick and dirty way of doing that. There should be no conflicts, because the names of the language strings point out, that they only are for the PasswordSafetyChart.

@Flamifly
Copy link
Contributor Author

I understand now why it was implemented like that..
The first is the negativ Translations
The second is the positiv Translation
The last is the unknown Translation

Does someone have a idea to have a good way of translation that?

@Flamifly
Copy link
Contributor Author

I could create 3 different Sentences for each Sentence which are very similar to the others

@Flamifly
Copy link
Contributor Author

Flamifly commented Dec 17, 2024

I have a different idea
instead of
image

use:
lower case letters: true
upper case letters: true
minimum password length: true
...
just telling the categorie and if it's true

By that there is one Sentence and only the bool have to be translated

Should I change it that way?

@FrozenAssassine
Copy link
Owner

Well, your idea is pretty simple and ngl I really love that😅

@Flamifly
Copy link
Contributor Author

I will change it to that tomorrow
I also added additional Translations in https://github.com/Flamifly/EasePass/tree/translation2

Tomorrow i will translate the InfoMessages too
image

@Flamifly
Copy link
Contributor Author

How can I translate the Paragraphs btw?
image

@FrozenAssassine
Copy link
Owner

Awesome man ❤️

I don't think we have to translate the Paragraphs or what do you think?

BTW I also added a little new feature with the following new language Strings, I did not merge or commit yet, but I just write so we don't forget lol.
I don't think its smart to add them to the language files now, because we could run into merge issues with your changes:

  • View_ManageDB_ExportDBNewPW -> ManageDatabasePage.xaml
  • View_PasswordPage_Flyout_ExportNewPassword -> PasswordPage.xaml

@Flamifly
Copy link
Contributor Author

I mean the most people understand english so it is not necessary at all but I personally would say it would be good to translate the privacy policy

What does this Feature do?
Is that the Feature to Backup the Database?

@FrozenAssassine
Copy link
Owner

Well you are correct since the app ships in two languages, it would be the best, to fully translate those languages then.
I could try to translate it for you?

The feature is so you can select some items from the password item pane and rightclick on export diff PW, and a dialog will open up so you can export the selected items from the list as a new database with your given password. This is useful when transferring passwords from one device to another or so.

@Flamifly
Copy link
Contributor Author

Flamifly commented Dec 17, 2024

I can Translate it if you show me how it works on paragraphs

That sounds cool

I am gone for today see ya

@FrozenAssassine
Copy link
Owner

I will give you an example see ya✌️

@FrozenAssassine
Copy link
Owner

How can I translate the Paragraphs btw? image

Oh I just found out, that there are already translation x:Uid in the image you send. But they are just not inside the resource files. So it should be no problem to add them without any trouble.

FrozenAssassine added a commit that referenced this issue Dec 17, 2024
@Flamifly
Copy link
Contributor Author

I will get on track on that Issue on Friday because today and tomorrow I have not enough time

@Flamifly
Copy link
Contributor Author

Better?
image

@FrozenAssassine
Copy link
Owner

I actually like it, way simpler than before I guess.
What do you think @finn-freitag?

@finn-freitag
Copy link
Collaborator

Yes, I think it's good and also easy to translate.

@Flamifly
Copy link
Contributor Author

It's not translated 100% so don't merge my translation branch

@Flamifly
Copy link
Contributor Author

Anyone have a good short english translation for the Passwordlength thing?

@finn-freitag
Copy link
Collaborator

Full Length:

  • English: Password length
  • German: Passwortlänge

Short:

  • English: Length
  • German: Länge

@Flamifly
Copy link
Contributor Author

Does this show if the minimum has reached?

@FrozenAssassine
Copy link
Owner

But shouldn't it mean sth like "save length". So whether the length of the password is save?

@Flamifly
Copy link
Contributor Author

Flamifly commented Dec 20, 2024

Or Password length: secure / unsecure?

@FrozenAssassine
Copy link
Owner

Oh yeah way better actually

@finn-freitag
Copy link
Collaborator

finn-freitag commented Dec 20, 2024

You can't really say that a password is secure from a certain length. "Password length: True" should be displayed if the length is greater than or equal to the minimum length entered in the settings.

I would replace "true/false" or "secure/insecure" trough "meets minimum/doesn't meet minimun".

@Flamifly
Copy link
Contributor Author

I will change it to meets minimum tomorrow and will add german translation

@Flamifly
Copy link
Contributor Author

German:
image

English;
image

Would be done with the translations if the translations are good

Flamifly pushed a commit to Flamifly/EasePass that referenced this issue Dec 21, 2024
@finn-freitag
Copy link
Collaborator

finn-freitag commented Dec 21, 2024

The German word “Passwordlänge” is written together and for “Veröffentlicht” the boolean value is not translated (at least in your screenshot), maybe you can correct that. Otherwise, good work!

@Flamifly
Copy link
Contributor Author

Need to change it quick thanks

@Flamifly
Copy link
Contributor Author

Changed it but need to test it might throw errors because edited it on my phone

@Flamifly
Copy link
Contributor Author

Messed up with the change as I mentioned so had to fix it

  • it can be compiled and executed now

German translation now:
image

FrozenAssassine added a commit that referenced this issue Dec 21, 2024
Adding/Chaning Translations for #133 and Fixed #156 in addition added Info Messages
@Flamifly
Copy link
Contributor Author

Not translated
image
image

Plugin Dialog

@Flamifly
Copy link
Contributor Author

A Translation is messing for the Export with different Password
I can fix it later or you guys can

@FrozenAssassine
Copy link
Owner

Oh, totally forgot to translate this. I'll do it real quick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants