-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Translations #133
Comments
I saw you changed the way PasswordSafetyChart.xaml will be translated there is a wrong term |
Oh wait @finn-freitag changed the way the PasswordSafetyChart handles translations, so now all translations are handled in the xaml file directly. I really think this is the better approach. I hope this does not break your changes too much. I will merge this now and I hope everything works fine with emerging on your end then. |
All good there was just some wrong terms at this point |
Yeah, this makes sense, I left the password safety chart a bit untouched in the way of translations due to those weird things that happen when translating to German. But I think you are on the right track there. Do you have a better approach to reworking this, would be awesome. |
I will change my stuff don't worry |
https://github.com/Flamifly/EasePass/tree/translation2 |
should be finished |
#133 (comment) |
Thank you very much, we really appreciate your work. @FrozenAssassine will merge that later. |
Your welcome 😄 |
@FrozenAssassine @finn-freitag is there a reason that you concat the translations? I would just do one translation for each prefix and not 3 different for each prefix. Is there anything that will be conflicted by that? |
I don't think there was a reason for that, at that time @finn-freitag did not properly know how to handle those translations and so we made a quick and dirty way of doing that. There should be no conflicts, because the names of the language strings point out, that they only are for the PasswordSafetyChart. |
I understand now why it was implemented like that.. Does someone have a idea to have a good way of translation that? |
I could create 3 different Sentences for each Sentence which are very similar to the others |
Well, your idea is pretty simple and ngl I really love that😅 |
I will change it to that tomorrow |
Awesome man ❤️ I don't think we have to translate the Paragraphs or what do you think? BTW I also added a little new feature with the following new language Strings, I did not merge or commit yet, but I just write so we don't forget lol.
|
I mean the most people understand english so it is not necessary at all but I personally would say it would be good to translate the privacy policy What does this Feature do? |
Well you are correct since the app ships in two languages, it would be the best, to fully translate those languages then. The feature is so you can select some items from the password item pane and rightclick on export diff PW, and a dialog will open up so you can export the selected items from the list as a new database with your given password. This is useful when transferring passwords from one device to another or so. |
I can Translate it if you show me how it works on paragraphs That sounds cool I am gone for today see ya |
I will give you an example see ya✌️ |
I will get on track on that Issue on Friday because today and tomorrow I have not enough time |
I actually like it, way simpler than before I guess. |
Yes, I think it's good and also easy to translate. |
It's not translated 100% so don't merge my translation branch |
Anyone have a good short english translation for the Passwordlength thing? |
Full Length:
Short:
|
Does this show if the minimum has reached? |
But shouldn't it mean sth like "save length". So whether the length of the password is save? |
Or Password length: secure / unsecure? |
Oh yeah way better actually |
You can't really say that a password is secure from a certain length. "Password length: True" should be displayed if the length is greater than or equal to the minimum length entered in the settings. I would replace "true/false" or "secure/insecure" trough "meets minimum/doesn't meet minimun". |
I will change it to meets minimum tomorrow and will add german translation |
The German word “Passwordlänge” is written together and for “Veröffentlicht” the boolean value is not translated (at least in your screenshot), maybe you can correct that. Otherwise, good work! |
Need to change it quick thanks |
Changed it but need to test it might throw errors because edited it on my phone |
A Translation is messing for the Export with different Password |
Oh, totally forgot to translate this. I'll do it real quick |
Fixed some wrong terms for the Translations and added missing once
https://github.com/Flamifly/EasePass/tree/translations
The text was updated successfully, but these errors were encountered: