Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more dynamic range for storing/draining Nature's Aura #14

Open
ubergarm opened this issue Aug 25, 2020 · 1 comment
Open

Add more dynamic range for storing/draining Nature's Aura #14

ubergarm opened this issue Aug 25, 2020 · 1 comment

Comments

@ubergarm
Copy link

ubergarm commented Aug 25, 2020

Firstly, thanks so much for this mod! It's amazing that it is even possible to glue together mana systems for a half dozen wonderful magic mods for an upcoming modpack Sky Magic Islands that I'm enjoying crafting!

I got a Modular Machine and recipe to convert RF/FE into Nature's Aura pretty quickly and have enough working, but I noticed that what Modular Magic calls "1 Aura" is actually 100,000 of Nature's Aura internal points because of these two lines of code:

https://github.com/Frinn38/Modular-Magic/blob/master/src/main/java/fr/frinn/modularmagic/common/tile/TileAuraProvider.java#L18

https://github.com/Frinn38/Modular-Magic/blob/master/src/main/java/fr/frinn/modularmagic/common/tile/TileAuraProvider.java#L24

Perhaps you were using that 100,000 multiplier to make it easier during debugging, or perhaps there is more going on than I'm aware of.

Regardless, is it possible to remove that 100,000 multiplier or make it smaller so that my Modular Machine recipes can store/drain Aura in amounts smaller than 100,000? (I tried setting the recipe to be say 0.001 Aura, but it seems to round down to zero)

Here is an example recipe that I'm playing with for you or anyone else interested as I didn't find much documentation:
EDIT: Added full namespaces to aura and energy

{
    "machine": "philosophers_engine",
    "registryName": "philosophers_engine_natures_aura",
    "recipeTime": 600,
    "requirements": [
        {
            "type": "modularmagic:aura",
            "io-type": "output",
            "aura-type": "naturesaura:overworld",
            "amount": 1
        },
        {
            "type": "modularmachinery:energy",
            "io-type": "input",
            "energyPerTick": 128
        } 
    ]
}

If you can't change it etc, no worries, I'll just increase that recipeTime instead to get the results in the scale for which I'm looking.

Thanks much!!!

@ubergarm
Copy link
Author

Also, not that it matters technically, my modpack doesn't actually have anything that uses/generates/consumes RF/FE power, but it is a convenient "medium" for converting mana types across many mods! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant