Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetting confirmation token never expires?? #2608

Open
ovgray opened this issue Sep 20, 2017 · 1 comment
Open

Resetting confirmation token never expires?? #2608

ovgray opened this issue Sep 20, 2017 · 1 comment

Comments

@ovgray
Copy link

ovgray commented Sep 20, 2017

Symfony FOSUserBundle versions: v2.0.1

Description of the problem including expected versus actual behavior:

A user who requests a password reset is redirected to a check-email page that says the user has been sent an email containing a link that will expire in two hours.

If that link isn't used in two hours (or two days, or two months), the link redirects to to the resetting request page. But if the user submits the request again, the user is sent the same "expired" link.

Shouldn't a new confirmation token be generated when the existing one is more than retry_ttl old, or at least when it is more than token_ttl old?

It seems that ResettingController::sendEmailAction will use $user->getConfirmationToken() no matter how long ago the token was created.

@willemstuursma
Copy link

So, the validity of a token that has been expired can easily be extended by requesting another reset?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants