refactor: run rector and phpstan again

FriendsOfCXML · May 31, 2024 · f6adee4 · f6adee4
1 parent 53ab409
commit f6adee4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/src/CXml/Model/Request/ConfirmationHeader.php b/src/CXml/Model/Request/ConfirmationHeader.php
@@ -36,7 +36,7 @@ public function __construct(
         #[Serializer\XmlAttribute]
         private readonly string $type,
         #[Serializer\XmlAttribute]
-        private ?\DateTimeInterface $noticeDate = null,
+        private readonly \DateTimeInterface $noticeDate = new \DateTime(),
     ) {
         Assertion::inArray($type, [
             self::TYPE_ACCEPT,
@@ -48,11 +48,9 @@ public function __construct(
             self::TYPE_REQUESTTOPAY,
             self::TYPE_REPLACE,
         ]);
-
-        $this->noticeDate = $noticeDate ?? new \DateTime();
     }
 
-    public static function create(string $type, \DateTimeInterface $noticeDate = null): self
+    public static function create(string $type, \DateTimeInterface $noticeDate = new \DateTime()): self
     {
         return new self(
             $type,
@@ -65,7 +63,7 @@ public function getType(): string
         return $this->type;
     }
 
-    public function getNoticeDate(): ?\DateTimeInterface
+    public function getNoticeDate(): \DateTimeInterface
     {
         return $this->noticeDate;
     }

diff --git a/src/CXml/Model/Request/OrderRequestHeader.php b/src/CXml/Model/Request/OrderRequestHeader.php
@@ -59,9 +59,15 @@ protected function __construct(
         #[Serializer\XmlList(entry: 'Contact', inline: true)]
         private ?array $contacts = null,
     ) {
-        if (null !== $contacts && [] !== $contacts) {
-            Assertion::allIsInstanceOf($contacts, Contact::class);
+        if (null === $contacts) {
+            return;
         }
+
+        if ([] === $contacts) {
+            return;
+        }
+
+        Assertion::allIsInstanceOf($contacts, Contact::class);
     }
 
     public static function create(