Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename then to and_then #23

Open
MatheusRich opened this issue Feb 26, 2021 · 2 comments
Open

Rename then to and_then #23

MatheusRich opened this issue Feb 26, 2021 · 2 comments
Assignees
@bvicenzo
Labels
breaking change needs discussion

Comments

@MatheusRich
Copy link
Contributor

MatheusRich commented Feb 26, 2021 •
edited
Loading

then already exist in ruby objects. It may be a good idea not to use the same method name in FService::Results. and_then is a pretty straight forward alternative.
@MatheusRich
Copy link
Contributor Author

MatheusRich commented Mar 8, 2021 •
edited
Loading

v0.2.0 added and_then as an alias to then to start the migration smoothly. The next release will mark .then as deprecated.

@bvicenzo bvicenzo mentioned this issue Dec 15, 2022
Merged
@bvicenzo
Copy link
Contributor

We are using the method #and_then for a while. Perhaps there is no place using then nowadays. Then, we are starting the process for removing this.

@bvicenzo bvicenzo self-assigned this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvicenzo bvicenzo

Labels
breaking change needs discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bvicenzo @MatheusRich