Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_windows.py was overwritten with linux version #55

Open
gkarsai opened this issue Feb 10, 2024 · 1 comment
Open

setup_windows.py was overwritten with linux version #55

gkarsai opened this issue Feb 10, 2024 · 1 comment

Comments

@gkarsai
Copy link

gkarsai commented Feb 10, 2024

setup_windows.py now contains linux code (e.g. sudo....) - it was overwritten in 2022?

@fire-eggs
Copy link

Yup, that's what it looks like to me. Overwritten on August 9, 2023.

Even the previous version is a little messed up, e.g. the message Please run 'sudo python setup_windows.py' again.

The previous version also is inconsistent with respect to the python version (a mix of python and python3 commands).

Looking at the other changes in that August 9, 2023 commit, it appears the goal for setup files was to add additional messaging for error handling. So I'd try the previous version, keeping the above issues in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants