Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A year earlier than 1300 is not accepted by FreeREG #2609

Open
SteveBiggs opened this issue Oct 26, 2022 · 7 comments
Open

A year earlier than 1300 is not accepted by FreeREG #2609

SteveBiggs opened this issue Oct 26, 2022 · 7 comments

Comments

@SteveBiggs
Copy link
Collaborator

The earliest year that FreeREG will accept in a transcription is 1300. There are records that give earlier years so we should be able to enter them.

@richardofsussex
Copy link

I won't get involved in coding FreeREG, but the relevant value (YEAR_MIN) is set in /lib/freereg_validations.rb. Presumably we need a minimum year for validation purposes: so what should it be, @SteveBiggs?

@edickens
Copy link

I seem to remember that we could enter even earlier than 1000. The problem was a leading zero. But it could have been in FR1.
Is it possibke to edit the entry after uploading without validation?

@richardofsussex
Copy link

In what context do you hit this limit? When entering actual records? From an examination of the (Rails) code, YEAR_MIN is primarily used as a start point when calculating numbers for places, churches and registers.

@Sherlock21
Copy link

Sherlock21 commented Oct 27, 2022 via email

@SteveBiggs
Copy link
Collaborator Author

Ideally, there would be no limit to the year but we certainly need to be able to go pre-1000. Maybe 0000 should be the limit (however, there are known records of births of Kings, etc. even BC!) I don't know why 1300 was chosen as a lower limit.

I tried editing a record on FreeREG and it does not allow any date before 1300.

@Sherlock21
Copy link

Sherlock21 commented Oct 28, 2022 via email

@DeniseColbert
Copy link
Contributor

@Captainkirkdawson do you have any ideas on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants