From 26984e1a6769ee59db7d99f18b31475e29ee2de2 Mon Sep 17 00:00:00 2001 From: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com> Date: Fri, 20 Dec 2024 18:27:24 +0100 Subject: [PATCH 1/5] standardize names for builds --- .github/workflows/build.yml | 46 +++++++++++++++++------------------ .github/workflows/release.yml | 24 +++++++++--------- 2 files changed, 35 insertions(+), 35 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5d34902f607ac..21fd6e99c8d85 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -117,91 +117,91 @@ jobs: uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-x64') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_linux_portable_x64 + name: freetube-${{ steps.versionNumber.outputs.result }}-linux-x64-portable.zip path: build/freetube-${{ steps.versionNumber.outputs.result }}.zip - name: Upload Linux .7z x64 Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-x64') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_linux_portable_x64.7z + name: freetube-${{ steps.versionNumber.outputs.result }}-linux-x64-portable.7z path: build/freetube-${{ steps.versionNumber.outputs.result }}.7z - name: Upload Linux .zip ARMv7l Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-armv7l') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_linux_portable_armv7l + name: freetube-${{ steps.versionNumber.outputs.result }}-linux-armv7l-portable.zip path: build/freetube-${{ steps.versionNumber.outputs.result }}-armv7l.zip - name: Upload Linux .7z ARMv7l Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-armv7l') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_linux_portable_armv7l.7z + name: freetube-${{ steps.versionNumber.outputs.result }}-linux-armv7l-portable.7z path: build/freetube-${{ steps.versionNumber.outputs.result }}-armv7l.7z - name: Upload Linux .zip ARM64 Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-arm64') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_linux_portable_arm64 + name: freetube-${{ steps.versionNumber.outputs.result }}-linux-arm64-portable.zip path: build/freetube-${{ steps.versionNumber.outputs.result }}-arm64.zip - name: Upload Linux .7z ARM64 Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-arm64') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_linux_portable_arm64.7z + name: freetube-${{ steps.versionNumber.outputs.result }}-linux-arm64-portable.7z path: build/freetube-${{ steps.versionNumber.outputs.result }}-arm64.7z - name: Upload .deb x64 Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-x64') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_amd64.deb + name: freetube-${{ steps.versionNumber.outputs.result }}-amd64.deb path: build/freetube_${{ steps.versionNumber.outputs.result }}_amd64.deb - name: Upload .deb ARMv7l Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-armv7l') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_armv7l.deb + name: freetube-${{ steps.versionNumber.outputs.result }}-armv7l.deb path: build/freetube_${{ steps.versionNumber.outputs.result }}_armv7l.deb - name: Upload .deb ARM64 Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-arm64') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_arm64.deb + name: freetube-${{ steps.versionNumber.outputs.result }}-arm64.deb path: build/freetube_${{ steps.versionNumber.outputs.result }}_arm64.deb - name: Upload AppImage x64 Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-x64') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_amd64.AppImage + name: freetube-${{ steps.versionNumber.outputs.result }}-amd64.AppImage path: build/FreeTube-${{ steps.versionNumber.outputs.result }}.AppImage - name: Upload AppImage ARMv7l Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-armv7l') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_armv7l.AppImage + name: freetube-${{ steps.versionNumber.outputs.result }}-armv7l.AppImage path: build/FreeTube-${{ steps.versionNumber.outputs.result }}-armv7l.AppImage - name: Upload AppImage ARM64 Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-arm64') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_arm64.AppImage + name: freetube-${{ steps.versionNumber.outputs.result }}-arm64.AppImage path: build/FreeTube-${{ steps.versionNumber.outputs.result }}-arm64.AppImage - name: Upload .rpm x64 Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-x64') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_amd64.rpm + name: freetube-${{ steps.versionNumber.outputs.result }}-amd64.rpm path: build/freetube-${{ steps.versionNumber.outputs.result }}.x86_64.rpm # rpm are not built for armv7l @@ -210,42 +210,42 @@ jobs: uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-arm64') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_arm64.rpm + name: freetube-${{ steps.versionNumber.outputs.result }}-arm64.rpm path: build/freetube-${{ steps.versionNumber.outputs.result }}.aarch64.rpm - name: Upload Alpine .apk x64 Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-x64') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_alpine_amd64.apk + name: freetube-${{ steps.versionNumber.outputs.result }}-alpine-amd64.apk path: build/freetube-${{ steps.versionNumber.outputs.result }}.apk - name: Upload Alpine .apk ARMv7l Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-armv7l') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_alpine_armv7l.apk + name: freetube-${{ steps.versionNumber.outputs.result }}-alpine-armv7l.apk path: build/freetube-${{ steps.versionNumber.outputs.result }}-armv7l.apk - name: Upload Alpine .apk ARM64 Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-arm64') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_alpine_arm64.apk + name: freetube-${{ steps.versionNumber.outputs.result }}-alpine-arm64.apk path: build/freetube-${{ steps.versionNumber.outputs.result }}-arm64.apk - name: Upload Pacman .pacman x64 Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-x64') with: - name: freetube_${{ steps.versionNumber.outputs.result }}_amd64.pacman + name: freetube-${{ steps.versionNumber.outputs.result }}-amd64.pacman path: build/freetube-${{ steps.versionNumber.outputs.result }}.pacman # - name: Upload Web Build # uses: actions/upload-artifact@v4 # if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-x64') # with: - # name: freetube_${{ steps.versionNumber.outputs.result }}_static_web + # name: freetube-${{ steps.versionNumber.outputs.result }}-static-web # path: dist/web - name: Upload Windows x64 .exe Artifact @@ -266,7 +266,7 @@ jobs: uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'windows') && startsWith(matrix.runtime, 'win-x64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-win-x64-portable + name: freetube-${{ steps.versionNumber.outputs.result }}-win-x64-portable.zip path: build/freetube-${{ steps.versionNumber.outputs.result }}-win.zip - name: Upload Windows x64 .7z Artifact @@ -280,7 +280,7 @@ jobs: uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'windows') && startsWith(matrix.runtime, 'win-arm64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-win-arm64-portable + name: freetube-${{ steps.versionNumber.outputs.result }}-win-arm64-portable.zip path: build/freetube-${{ steps.versionNumber.outputs.result }}-arm64-win.zip - name: Upload Windows arm64 .7z Artifact @@ -294,14 +294,14 @@ jobs: uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'windows') && startsWith(matrix.runtime, 'win-x64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-portable-x64.exe + name: freetube-${{ steps.versionNumber.outputs.result }}-win-x64-portable.exe path: build/freetube ${{ steps.versionNumber.outputs.result }}.exe - name: Upload Windows arm64 Portable Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'windows') && startsWith(matrix.runtime, 'win-arm64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-portable-arm64.exe + name: freetube-${{ steps.versionNumber.outputs.result }}-win-arm64-portable.exe path: build/freetube ${{ steps.versionNumber.outputs.result }}.exe - name: Upload Mac x64 .dmg Artifact diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 7438d0c110de5..af30fbf7936f7 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -91,7 +91,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube_${{ steps.getPackageInfo.outputs.version }}_amd64.AppImage + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-amd64.AppImage asset_path: build/FreeTube-${{ steps.getPackageInfo.outputs.version }}.AppImage asset_content_type: application/vnd.appimage @@ -102,7 +102,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-linux-portable-x64.zip + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-linux-x64-portable.zip asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}.zip asset_content_type: application/zip @@ -113,7 +113,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-linux-portable-x64.7z + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-linux-x64-portable.7z asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}.7z asset_content_type: application/x-7z-compressed @@ -124,7 +124,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-linux-portable-armv7l.zip + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-linux-armv7l-portable.zip asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}-armv7l.zip asset_content_type: application/zip @@ -135,7 +135,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-linux-portable-armv7l.7z + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-linux-armv7l-portable.7z asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}-armv7l.7z asset_content_type: application/x-7z-compressed @@ -146,7 +146,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-linux-portable-arm64.zip + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-linux-arm64-portable.zip asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}-arm64.zip asset_content_type: application/zip @@ -157,7 +157,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-linux-portable-arm64.7z + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-linux-arm64-portable.7z asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}-arm64.7z asset_content_type: application/x-7z-compressed @@ -168,7 +168,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube_${{ steps.getPackageInfo.outputs.version }}_amd64.deb + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-amd64.deb asset_path: build/freetube_${{ steps.getPackageInfo.outputs.version }}_amd64.deb asset_content_type: application/vnd.debian.binary-package @@ -179,7 +179,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube_${{ steps.getPackageInfo.outputs.version }}_armv7l.deb + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-armv7l.deb asset_path: build/freetube_${{ steps.getPackageInfo.outputs.version }}_armv7l.deb asset_content_type: application/vnd.debian.binary-package @@ -190,7 +190,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube_${{ steps.getPackageInfo.outputs.version }}_arm64.deb + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-arm64.deb asset_path: build/freetube_${{ steps.getPackageInfo.outputs.version }}_arm64.deb asset_content_type: application/vnd.debian.binary-package @@ -201,7 +201,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube_${{ steps.getPackageInfo.outputs.version }}_amd64.rpm + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-amd64.rpm asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}.x86_64.rpm asset_content_type: application/x-rpm @@ -214,7 +214,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube_${{ steps.getPackageInfo.outputs.version }}_arm64.rpm + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-arm64.rpm asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}.aarch64.rpm asset_content_type: application/x-rpm From 04bcda4c9962da205e7d067b5d2bbc171537c3de Mon Sep 17 00:00:00 2001 From: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com> Date: Sun, 22 Dec 2024 20:16:17 +0100 Subject: [PATCH 2/5] use .deb and .rpm standard pkg name convention --- .github/workflows/build.yml | 10 +++++----- .github/workflows/release.yml | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 21fd6e99c8d85..a6babe6d42ee5 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -159,21 +159,21 @@ jobs: uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-x64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-amd64.deb + name: freetube_${{ steps.versionNumber.outputs.result }}_amd64.deb path: build/freetube_${{ steps.versionNumber.outputs.result }}_amd64.deb - name: Upload .deb ARMv7l Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-armv7l') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-armv7l.deb + name: freetube_${{ steps.versionNumber.outputs.result }}_armv7l.deb path: build/freetube_${{ steps.versionNumber.outputs.result }}_armv7l.deb - name: Upload .deb ARM64 Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-arm64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-arm64.deb + name: freetube_${{ steps.versionNumber.outputs.result }}_arm64.deb path: build/freetube_${{ steps.versionNumber.outputs.result }}_arm64.deb - name: Upload AppImage x64 Artifact @@ -201,7 +201,7 @@ jobs: uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-x64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-amd64.rpm + name: freetube-${{ steps.versionNumber.outputs.result }}.amd64.rpm path: build/freetube-${{ steps.versionNumber.outputs.result }}.x86_64.rpm # rpm are not built for armv7l @@ -210,7 +210,7 @@ jobs: uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.runtime, 'linux-arm64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-arm64.rpm + name: freetube-${{ steps.versionNumber.outputs.result }}.arm64.rpm path: build/freetube-${{ steps.versionNumber.outputs.result }}.aarch64.rpm - name: Upload Alpine .apk x64 Artifact diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d6b81e8b56276..011e0493ad360 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -190,7 +190,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-amd64.deb + asset_name: freetube_${{ steps.getPackageInfo.outputs.version }}_amd64.deb asset_path: build/freetube_${{ steps.getPackageInfo.outputs.version }}_amd64.deb asset_content_type: application/vnd.debian.binary-package @@ -201,7 +201,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-armv7l.deb + asset_name: freetube_${{ steps.getPackageInfo.outputs.version }}_armv7l.deb asset_path: build/freetube_${{ steps.getPackageInfo.outputs.version }}_armv7l.deb asset_content_type: application/vnd.debian.binary-package @@ -212,7 +212,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-arm64.deb + asset_name: freetube_${{ steps.getPackageInfo.outputs.version }}_arm64.deb asset_path: build/freetube_${{ steps.getPackageInfo.outputs.version }}_arm64.deb asset_content_type: application/vnd.debian.binary-package @@ -223,7 +223,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-amd64.rpm + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}.amd64.rpm asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}.x86_64.rpm asset_content_type: application/x-rpm @@ -236,7 +236,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-arm64.rpm + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}.arm64.rpm asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}.aarch64.rpm asset_content_type: application/x-rpm From 2ad237d8dab034af29038e8bcdb6a8479ed963b6 Mon Sep 17 00:00:00 2001 From: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com> Date: Sat, 28 Dec 2024 02:25:00 +0100 Subject: [PATCH 3/5] include portable in name for 7z and zip builds --- .github/workflows/build.yml | 8 ++++---- .github/workflows/release.yml | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a6babe6d42ee5..61971ff0fd21f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -322,26 +322,26 @@ jobs: uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'macos') && startsWith(matrix.runtime, 'osx-x64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-mac-x64.zip + name: freetube-${{ steps.versionNumber.outputs.result }}-mac-x64-portable.zip path: build/freetube-${{ steps.versionNumber.outputs.result }}-mac.zip - name: Upload Mac x64 .7z Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'macos') && startsWith(matrix.runtime, 'osx-x64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-mac-x64.7z + name: freetube-${{ steps.versionNumber.outputs.result }}-mac-x64-portable.7z path: build/freetube-${{ steps.versionNumber.outputs.result }}-mac.7z - name: Upload Mac arm64 .zip Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'macos') && startsWith(matrix.runtime, 'osx-arm64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-mac-arm64.zip + name: freetube-${{ steps.versionNumber.outputs.result }}-mac-arm64-portable.zip path: build/freetube-${{ steps.versionNumber.outputs.result }}-arm64-mac.zip - name: Upload Mac arm64 .7z Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'macos') && startsWith(matrix.runtime, 'osx-arm64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-mac-arm64.7z + name: freetube-${{ steps.versionNumber.outputs.result }}-mac-arm64-portable.7z path: build/freetube-${{ steps.versionNumber.outputs.result }}-arm64-mac.7z diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 011e0493ad360..946ddf28caf96 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -357,7 +357,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-x64.zip + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-x64-portable.zip asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}-mac.zip asset_content_type: application/zip @@ -368,7 +368,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-x64.7z + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-x64-portable.7z asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}-mac.7z asset_content_type: application/x-7z-compressed @@ -379,7 +379,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-arm64.zip + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-arm64-portable.zip asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}-arm64-mac.zip asset_content_type: application/x-apple-diskimage @@ -390,7 +390,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-arm64.7z + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-arm64-portable.7z asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}-arm64-mac.7z asset_content_type: application/x-7z-compressed From 3e734ee0f5e37bf0ea4064def9afd080462a4dfb Mon Sep 17 00:00:00 2001 From: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com> Date: Sat, 28 Dec 2024 19:01:24 +0100 Subject: [PATCH 4/5] revert portable naming for mac builds --- .github/workflows/build.yml | 8 ++++---- .github/workflows/release.yml | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 61971ff0fd21f..a6babe6d42ee5 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -322,26 +322,26 @@ jobs: uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'macos') && startsWith(matrix.runtime, 'osx-x64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-mac-x64-portable.zip + name: freetube-${{ steps.versionNumber.outputs.result }}-mac-x64.zip path: build/freetube-${{ steps.versionNumber.outputs.result }}-mac.zip - name: Upload Mac x64 .7z Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'macos') && startsWith(matrix.runtime, 'osx-x64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-mac-x64-portable.7z + name: freetube-${{ steps.versionNumber.outputs.result }}-mac-x64.7z path: build/freetube-${{ steps.versionNumber.outputs.result }}-mac.7z - name: Upload Mac arm64 .zip Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'macos') && startsWith(matrix.runtime, 'osx-arm64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-mac-arm64-portable.zip + name: freetube-${{ steps.versionNumber.outputs.result }}-mac-arm64.zip path: build/freetube-${{ steps.versionNumber.outputs.result }}-arm64-mac.zip - name: Upload Mac arm64 .7z Artifact uses: actions/upload-artifact@v4 if: startsWith(matrix.os, 'macos') && startsWith(matrix.runtime, 'osx-arm64') with: - name: freetube-${{ steps.versionNumber.outputs.result }}-mac-arm64-portable.7z + name: freetube-${{ steps.versionNumber.outputs.result }}-mac-arm64.7z path: build/freetube-${{ steps.versionNumber.outputs.result }}-arm64-mac.7z diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 946ddf28caf96..011e0493ad360 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -357,7 +357,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-x64-portable.zip + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-x64.zip asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}-mac.zip asset_content_type: application/zip @@ -368,7 +368,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-x64-portable.7z + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-x64.7z asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}-mac.7z asset_content_type: application/x-7z-compressed @@ -379,7 +379,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-arm64-portable.zip + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-arm64.zip asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}-arm64-mac.zip asset_content_type: application/x-apple-diskimage @@ -390,7 +390,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: https://uploads.github.com/repos/FreeTubeApp/FreeTube/releases/${{ secrets.UPLOAD_ID }}/assets{?name,label} - asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-arm64-portable.7z + asset_name: freetube-${{ steps.getPackageInfo.outputs.version }}-mac-arm64.7z asset_path: build/freetube-${{ steps.getPackageInfo.outputs.version }}-arm64-mac.7z asset_content_type: application/x-7z-compressed From 58bfde3ce0196763eda2de9c275d9ac017e9d79f Mon Sep 17 00:00:00 2001 From: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com> Date: Sun, 29 Dec 2024 18:17:31 +0100 Subject: [PATCH 5/5] change names in flatpak workflow --- .github/workflows/flatpak.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/flatpak.yml b/.github/workflows/flatpak.yml index 217f4c926cc43..b108a769c4497 100644 --- a/.github/workflows/flatpak.yml +++ b/.github/workflows/flatpak.yml @@ -51,24 +51,24 @@ jobs: with: version: v${{ steps.sub.outputs.result }}-beta repository: FreeTubeApp/FreeTube - file: freetube-${{ steps.sub.outputs.result }}-linux-portable-x64.zip + file: freetube-${{ steps.sub.outputs.result }}-linux-x64-portable.zip - name: Download ARM Release uses: fabriciobastian/download-release-asset-action@v1.0.6 with: version: v${{ steps.sub.outputs.result }}-beta repository: FreeTubeApp/FreeTube - file: freetube-${{ steps.sub.outputs.result }}-linux-portable-arm64.zip + file: freetube-${{ steps.sub.outputs.result }}-linux-arm64-portable.zip - name: Set x64 Hash Variable id: hash-x64 run: | echo 'HASH_X64<> $GITHUB_ENV - sha256sum freetube-${{ steps.sub.outputs.result }}-linux-portable-x64.zip | awk '{print $1}' >> $GITHUB_ENV + sha256sum freetube-${{ steps.sub.outputs.result }}-linux-x64-portable.zip | awk '{print $1}' >> $GITHUB_ENV echo 'EOF' >> $GITHUB_ENV - name: Set ARM Hash Variable id: hash-arm64 run: | echo 'HASH_ARM64<> $GITHUB_ENV - sha256sum freetube-${{ steps.sub.outputs.result }}-linux-portable-arm64.zip | awk '{print $1}' >> $GITHUB_ENV + sha256sum freetube-${{ steps.sub.outputs.result }}-linux-arm64-portable.zip | awk '{print $1}' >> $GITHUB_ENV echo 'EOF' >> $GITHUB_ENV - name: Set Date Variable id: current-date @@ -80,7 +80,7 @@ jobs: uses: mikefarah/yq@v4.44.6 with: # The Command which should be run - cmd: yq -i '.modules[0].sources[0].url = "https://github.com/FreeTubeApp/FreeTube/releases/download/v${{ steps.sub.outputs.result }}-beta/freetube-${{ steps.sub.outputs.result }}-linux-portable-x64.zip"' io.freetubeapp.FreeTube.yml + cmd: yq -i '.modules[0].sources[0].url = "https://github.com/FreeTubeApp/FreeTube/releases/download/v${{ steps.sub.outputs.result }}-beta/freetube-${{ steps.sub.outputs.result }}-linux-x64-portable.zip"' io.freetubeapp.FreeTube.yml - name: Update x64 Hash in yml File uses: mikefarah/yq@v4.44.6 with: @@ -90,7 +90,7 @@ jobs: uses: mikefarah/yq@v4.44.6 with: # The Command which should be run - cmd: yq -i '.modules[0].sources[1].url = "https://github.com/FreeTubeApp/FreeTube/releases/download/v${{ steps.sub.outputs.result }}-beta/freetube-${{ steps.sub.outputs.result }}-linux-portable-arm64.zip"' io.freetubeapp.FreeTube.yml + cmd: yq -i '.modules[0].sources[1].url = "https://github.com/FreeTubeApp/FreeTube/releases/download/v${{ steps.sub.outputs.result }}-beta/freetube-${{ steps.sub.outputs.result }}-linux-arm64-portable.zip"' io.freetubeapp.FreeTube.yml - name: Update ARM Hash in yml File uses: mikefarah/yq@v4.44.6 with: @@ -100,8 +100,8 @@ jobs: run: xmlstarlet ed -L -i /application/releases/release[1] -t elem -n releaseTMP -v "" -i //releaseTMP -t attr -n version -v "${{ steps.sub.outputs.result }} Beta" -i //releaseTMP -t attr -n date -v "${{ env.CURRENT_DATE }}" -s //releaseTMP -t elem -n url -v "" -s //releaseTMP/url -t text -n "" -v "https://github.com/FreeTubeApp/FreeTube/releases/tag/v${{ steps.sub.outputs.result }}-beta" -r //releaseTMP -v "release" io.freetubeapp.FreeTube.metainfo.xml - name: Remove Release Files run: | - rm freetube-${{ steps.sub.outputs.result }}-linux-portable-x64.zip - rm freetube-${{ steps.sub.outputs.result }}-linux-portable-arm64.zip + rm freetube-${{ steps.sub.outputs.result }}-linux-x64-portable.zip + rm freetube-${{ steps.sub.outputs.result }}-linux-arm64-portable.zip - name: Commit Files uses: stefanzweifel/git-auto-commit-action@v5 with: