Added search button to search filters #6277
Conversation
github-actions
bot
added
the
PR: waiting for review
There was a problem hiding this comment.
In its current state this pull request feels overcomplicated. Please rewrite it to emit the query from the top-nav to the App component and pass it down to the search filters with a prop, then you can call router.push directly in the search filters component instead of misusing the store to forward your events.
absidue
added
PR: changes requested
and removed
PR: waiting for review
|
do we want to support creating new window by pressing shift? |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
|
I imagine people are using this to refine the existing search result Though if possible supporting it won't hurt |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
JL0000
force-pushed
the
add-search-button-to-search-filters
branch
from
fae77a3 to
f0f6ac1
Compare
Yes best to give the users the ability to do that here as well |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Added search button to search filters
Pull Request Type
Related issue
closes #6194
Description
Created a search button that applies the filters and triggers search in
Search Filters. Search button is only visible when there is text in the search box.There is no event passed to the search for this button, so will not duplicate window with
shift.Screenshots
Desktop