Change icon color of FT logo #4491
Conversation
Change icon color of FT logo Pull Request Type Feature Implementation Related issue closes FreeTubeApp#4020 Description Changed icon color of FT logo on based on set theme Available Methods :- As far as I can see, you have three choices: 1) I used an online tool to vectorize our existing logo. You can add it to _icons (our current icon SVG is using a raster image, which doesn't work for this), add it inline to the template, and use the fill CSS property to dynamically change the color to the --primary-text-color for that theme. logoBlack 2) You can create different versions of this logo icon by changing the fill="#ffffff" to the primary text color for the given theme and use those. 3) You can use an editor like GIMP to create logo images for the themes missing them (with the fill color of that theme's --primary-text-color) (probably more effort than two). Implemented 2 option :)
github-actions
bot
added
PR: dependencies
|
Please remove the yarn error log and revert the addition of |
|
I do like the idea of dynamically changing the colour :) |
absidue
added
PR: changes requested
and removed
PR: waiting for review
|
ok Sure |
Removed yarn-error.log removed package-lock.json removed yarn as a dependency sorry for package manager issue:)
Head branch was pushed to by a user without write access
|
Its done :) |
ChunkyProgrammer
added
PR: waiting for review
|
Ideally the logo on the about page should match the one in the navigation bar. Unfortunately this current approach, forces the logo to always be one single color, so you loose the blue and red colors, which makes this pull request a branding change. |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
worked on :- 1) eruihre 2)ioefje 3) feriu
Head branch was pushed to by a user without write access
|
This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
This PR was closed because it has been stalled for 14 days with no activity. |
Change icon color of FT logo
Pull Request Type
Feature Implementation
Related issue
closes #4020
Description
Changed icon color of FT logo on based on set theme
Available Methods :-
As far as I can see, you have three choices:
I used an online tool to vectorize our existing logo. You can add it to _icons (our current icon SVG is using a raster image, which doesn't work for this), add it inline to the template, and use the fill CSS property to dynamically change the color to the --primary-text-color for that theme. logoBlack
You can create different versions of this logo icon by changing the fill="#ffffff" to the primary text color for the given theme and use those.
You can use an editor like GIMP to create logo images for the themes missing them (with the fill color of that theme's --primary-text-color) (probably more effort than two).
Implemented 2 option :)