Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Avoid to buffer segments blocked by sponsorblock #4354

Closed
3 tasks done
stemy2 opened this issue Nov 19, 2023 · 1 comment
Closed
3 tasks done

[Feature Request]: Avoid to buffer segments blocked by sponsorblock #4354

stemy2 opened this issue Nov 19, 2023 · 1 comment

Comments

@stemy2
Copy link

stemy2 commented Nov 19, 2023

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Sponsorblocks are buffered, and it's a problem because when the said segment is being skipped, i have to wait another buffering time because it preffered to buffer a segment that i wouldn't watch anymay.

Proposed Solution

I'm not a technical person, so i don't know.

Alternatives Considered

I'm not a technical person, so i don't know.

Issue Labels

improvement to existing feature

Additional Information

No response

@stemy2 stemy2 added the enhancement New feature or request label Nov 19, 2023
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 20, 2023

Retrieved from IRC

I don't think any video player gives you that level of control, especially as most sponsor block segments are probably shorter than a segment of video, so it would need to be downloaded anyway if you want the stuff that is before and after the sponsor block segment to play

maybe if we patched the player dependency itself we could find some way of modifying it's internal segment list, but then we would also need to make sure that it can cope with sections of audio and video allegedly not existing.

Also don't forget that players tend to request multiple segments of audio and video at the same time, if the connection is good enough, so by doing those changes instead of doing one request for segments 1-4, we would have to do one request for segment 1 and a second request for segments 3 and 4, at which point the added overhead probably outweighs any benefit you would get

Based on this i'll go ahead and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants