Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: DeArrow not replacing unverified titles #4320

Closed
1 task
Mr-Bajs opened this issue Nov 12, 2023 · 5 comments · Fixed by #4321
Closed
1 task

[Bug]: DeArrow not replacing unverified titles #4320

Mr-Bajs opened this issue Nov 12, 2023 · 5 comments · Fixed by #4321

Comments

@Mr-Bajs
Copy link

Mr-Bajs commented Nov 12, 2023

It related to this where the issue are discussed but the issue i closed #3696 (comment)
I'll create this seperate issue for the particular issue of FreeTube not replaceing youtube original titles with the dearrows user submited titles, for the sake of keeping track of issues.

This comment and screenshots shows how the DeArrow titles doesn't load on FreeTube.
#3696 (comment)

Expected Behavior

Enable DeArrow in Freetube and look for for youtube videos that has user submitted titles and compare it with a browser with dearrow enabled.

Issue Labels

API issue, feature stopped working

FreeTube Version

v.0.19.1

Operating System Version

Linux Mint 21.2

Installation Method

Flathub

Primary API used

Local API

Nightly Build

@absidue
Copy link
Member

absidue commented Nov 12, 2023

As mentioned in the comments below the original one, this is caused by FreeTube only using titles that one or more DeArrow submitters upvoted, whereas the DeArrow browser extension shows everything, even if it has no votes.

The solution would be to lower the standards in FreeTube, so that it uses unverified submissions too. I guess the browser extension lowered it's standards since the original FreeTube pull request, because using ones with 1 or more votes was suggested by the DeArrow developer here: #3688 (comment)

@absidue absidue changed the title [Bug]: DeArrow not replaceing titels [Bug]: DeArrow not replacing unverified titles Nov 12, 2023
@Mr-Bajs
Copy link
Author

Mr-Bajs commented Nov 12, 2023

I think lowering the standard would be fine. Hence Dearrow is fairly new and its usage isnt widely adopted i think lowering the standard would be fine, if the useage and submissions would increase ahead FreeTube could raise it standards.

@ajayyy
Copy link
Contributor

ajayyy commented Nov 12, 2023

Sorry the original suggestion was a mistake. "Unverified" submissions appear as -1 votes, so still won't be used. Once a user has been verified as good, their submissions will start at 0.

I made a PR #4321

@Mr-Bajs
Copy link
Author

Mr-Bajs commented Nov 12, 2023

Sorry the original suggestion was a mistake. "Unverified" submissions appear as -1 votes, so still won't be used. Once a user has been verified as good, their submissions will start at 0.

I made a PR #4321

@ajayyy Okey, what makes a user verifed as good?

@ajayyy
Copy link
Contributor

ajayyy commented Nov 12, 2023

@Mr-Bajs at the moment you are labeled "verified" after receiving at least one vote on any title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants