defncopy: index names not properly escaped

[jonahgeorge]

It appears that defncopy does not properly escape index names when writing the create index command.

I was able to reproduce this on an existing table which has a column named FromDate and an index on said column named From Date:

CREATE TABLE dbo.tblReportPeriod
	( [RecordID]   int             NOT NULL
	, [FromDate]   nvarchar(40)        NULL
	, [ToDate]     nvarchar(40)        NULL
	)

CREATE  nonclustered INDEX [From Date] on dbo.tblReportPeriod([FromDate])

defncopy generated the following invalid SQL:

CREATE TABLE dbo.tblReportPeriod
	( RecordID   int             NOT NULL
	, FromDate   nvarchar(40)        NULL
	, ToDate     nvarchar(40)        NULL
	)

CREATE  nonclustered INDEX From Date on dbo.tblReportPeriod(FromDate)

Related

• Escape column names #276
• Support for structure.sql seems to be broken rails-sqlserver/activerecord-sqlserver-adapter#944
• Support for structure.sql seems to be broken rails-sqlserver/tiny_tds#502

[jonahgeorge]

Per comments in the linked PR, if this were to be fixed it appears that defncopy would need to know which quoting strategy to use (brackets for MSSQL vs quotes elsewhere). Would a CLI flag be acceptable?

[fziglio]

Sybase 15 introduced [] quoting so I think it would be safe now to use always [] style quoting. One issue of the PR is that it's not properly quoting. If the name is test]123 it needs to be quoted as [test]]123], not [test]123]. There's a tds_quote_id to quote identifier (there's also an internal tds_quote function).

[Michoels]

This is still a problem in 2024.

[freddy77]

Fixed in 1.4.12 (will be packaged automatically tomorrow) and master.