Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid git tag for V2.3.0 #296

Closed
BogdanTheGeek opened this issue Jul 9, 2024 · 7 comments
Closed

Invalid git tag for V2.3.0 #296

BogdanTheGeek opened this issue Jul 9, 2024 · 7 comments
Assignees

Comments

@BogdanTheGeek
Copy link

image Cannot checkout v2.2.0 or v2.3.0 as the tags don't belong to this repo.
@BogdanTheGeek
Copy link
Author

Also, the runtime version has not been update:

#define MQTT_LIBRARY_VERSION "v2.1.0"

@chinglee-iot
Copy link
Member

@BogdanTheGeek
Thank you for reporting the MQTT_LIBRARY_VERSION problem. We will fix this issue. As for the tag problem, the release is created from a branch. The branch will be deleted after the tag release, but the tag and commit will still exist.

@chinglee-iot chinglee-iot self-assigned this Jul 9, 2024
@BogdanTheGeek
Copy link
Author

@chinglee-iot It might be so, but that still means I can't checkout the tag. The tag should be created after merging into main.

@chinglee-iot
Copy link
Member

@BogdanTheGeek
After the branch is deleted, the commits referenced by the tag remain valid. Can you share us the error message you encountered when checking out the tag?

@moninom1
Copy link
Member

HI @BogdanTheGeek, Can you please help us know what error you are getting when checking out the tag?

@ActoryOu
Copy link
Member

Hi @BogdanTheGeek,
I can clone tag v2.3.0 successfully. Could you help provide the error message you met for futher analysis?

My clone log:

PS C:\git\temp> git clone -b v2.3.0 https://github.com/FreeRTOS/coreMQTT
Cloning into 'coreMQTT'...
remote: Enumerating objects: 7539, done.
remote: Counting objects: 100% (2288/2288), done.
remote: Compressing objects: 100% (367/367), done.
Receiving objects: 100% (7539/7539), 4.70 MiB | 2.26 MiB/s, done.eused 5251
Resolving deltas: 100% (5737/5737), done.
Note: switching to '3f4cedc1ad027d76b2f00c2f83481b212b7a8632'.

Thank you.

@ActoryOu
Copy link
Member

ActoryOu commented Aug 2, 2024

This issue is being closed as the reported behavior could not be reproduced in other environments after thorough testing. Nevertheless, if you continue to experience the same issue, feel free to reopen this ticket.

@ActoryOu ActoryOu closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants