From 5e1fe21668334a6b5148a75e18fd02093bebe86c Mon Sep 17 00:00:00 2001
From: Olivier <olivier@helitech>
Date: Thu, 2 Jan 2025 18:10:22 +0100
Subject: [PATCH] add custom errors compatible with std

 to be used for internal code and not abuse
 StatusCode errors from protocol
---
 Cargo.lock               |  1 +
 opcua-core/Cargo.toml    |  1 +
 opcua-core/src/errors.rs | 12 ++++++++++++
 opcua-core/src/lib.rs    |  3 +++
 samples/client.conf      | 20 ++++++++++----------
 5 files changed, 27 insertions(+), 10 deletions(-)
 create mode 100644 opcua-core/src/errors.rs

diff --git a/Cargo.lock b/Cargo.lock
index 0556d0633..34b1afb27 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1215,6 +1215,7 @@ dependencies = [
  "parking_lot",
  "serde",
  "serde_yaml",
+ "thiserror",
  "tokio",
  "tokio-util",
  "url",
diff --git a/opcua-core/Cargo.toml b/opcua-core/Cargo.toml
index 34bfc79bd..e062396ec 100644
--- a/opcua-core/Cargo.toml
+++ b/opcua-core/Cargo.toml
@@ -28,6 +28,7 @@ url = { workspace = true }
 
 opcua-types = { path = "../opcua-types" }
 opcua-crypto = { path = "../opcua-crypto" }
+thiserror.workspace = true
 
 
 [lints.rust]
diff --git a/opcua-core/src/errors.rs b/opcua-core/src/errors.rs
new file mode 100644
index 000000000..070bb020b
--- /dev/null
+++ b/opcua-core/src/errors.rs
@@ -0,0 +1,12 @@
+use opcua_types::{Variant, VariantScalarTypeId};
+use thiserror::Error;
+
+/// Rust OpcUa specific errors
+#[allow(missing_docs)]
+#[derive(Error, Debug)]
+pub enum OpcUAError {
+    #[error("Received an expected variant type")]
+    UnExpectedVariantType(Option<VariantScalarTypeId),
+    #[error("The requested namespace does not exists")]
+    NamespaceDoesNotExist(String),
+}
diff --git a/opcua-core/src/lib.rs b/opcua-core/src/lib.rs
index 14f8ad6e8..b78430450 100644
--- a/opcua-core/src/lib.rs
+++ b/opcua-core/src/lib.rs
@@ -66,6 +66,9 @@ pub mod comms;
 pub mod config;
 pub mod handle;
 
+/// Rust OpcUa specific errors
+pub mod errors;
+
 pub mod messages;
 pub use messages::{Message, MessageType, RequestMessage, ResponseMessage};
 
diff --git a/samples/client.conf b/samples/client.conf
index 4f87d09a8..ea41b25c7 100644
--- a/samples/client.conf
+++ b/samples/client.conf
@@ -9,13 +9,6 @@ verify_server_certs: true
 pki_dir: ./pki
 preferred_locales: []
 default_endpoint: sample_none
-user_tokens:
-  sample_user:
-    user: sample1
-    password: sample1pwd
-  sample_user2:
-    user: sample2
-    password: sample2pwd
 endpoints:
   sample_basic128rsa15:
     url: opc.tcp://127.0.0.1:4855/
@@ -37,6 +30,14 @@ endpoints:
     security_policy: None
     security_mode: None
     user_token_id: ANONYMOUS
+user_tokens:
+  sample_user:
+    user: sample1
+    password: sample1pwd
+  sample_user2:
+    user: sample2
+    password: sample2pwd
+channel_lifetime: 60000
 decoding_options:
   max_message_size: 327675
   max_chunk_count: 5
@@ -65,10 +66,9 @@ publish_timeout:
 min_publish_interval:
   secs: 0
   nanos: 100000000
-session_timeout: 60000
 performance:
   ignore_clock_skew: false
   recreate_monitored_items_chunk: 1000
-session_name: Rust OPC UA Client
-channel_lifetime: 60000
 recreate_subscriptions: true
+session_name: Rust OPC UA Client
+session_timeout: 60000