Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lots of clang-tidy warnings #54

Open
rursprung opened this issue Dec 3, 2024 · 0 comments
Open

lots of clang-tidy warnings #54

rursprung opened this issue Dec 3, 2024 · 0 comments

Comments

@rursprung
Copy link
Contributor

my IDE (CLion) automatically shows clang-tidy warnings and there are quite a lot of them in this project (+ also some validations from CLion itself).

you could enable clang-tidy by default in CI and let it upload the results to the PRs without failing the PRs (and you could probably configure it in such a way that new code mustn't have warnings while markers for unchanged code don't fail the build). this would give visibility to the problems.

on a related note: while in #42 you stated that you prefer not to add -Werror to all the builds may i suggest that you might want to have a CI build which adds -Werror (e.g. via environment variables) to check for errors? in CI you can control the used compiler so there should be no surprises there (+ in CI it might make sense to always test with the latest to catch new validations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant