You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
my IDE (CLion) automatically shows clang-tidy warnings and there are quite a lot of them in this project (+ also some validations from CLion itself).
you could enable clang-tidy by default in CI and let it upload the results to the PRs without failing the PRs (and you could probably configure it in such a way that new code mustn't have warnings while markers for unchanged code don't fail the build). this would give visibility to the problems.
on a related note: while in #42 you stated that you prefer not to add -Werror to all the builds may i suggest that you might want to have a CI build which adds -Werror (e.g. via environment variables) to check for errors? in CI you can control the used compiler so there should be no surprises there (+ in CI it might make sense to always test with the latest to catch new validations).
The text was updated successfully, but these errors were encountered:
my IDE (CLion) automatically shows clang-tidy warnings and there are quite a lot of them in this project (+ also some validations from CLion itself).
you could enable clang-tidy by default in CI and let it upload the results to the PRs without failing the PRs (and you could probably configure it in such a way that new code mustn't have warnings while markers for unchanged code don't fail the build). this would give visibility to the problems.
on a related note: while in #42 you stated that you prefer not to add
-Werror
to all the builds may i suggest that you might want to have a CI build which adds-Werror
(e.g. via environment variables) to check for errors? in CI you can control the used compiler so there should be no surprises there (+ in CI it might make sense to always test with the latest to catch new validations).The text was updated successfully, but these errors were encountered: