Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter Yaml #48

Open
boitumeloruf opened this issue Dec 2, 2024 · 3 comments
Open

Parameter Yaml #48

boitumeloruf opened this issue Dec 2, 2024 · 3 comments
Labels
feature New feature request

Comments

@boitumeloruf
Copy link
Collaborator

Currently the camera is configured using a (possibly) long list of launch parameters.

A new feature could be to allow the specification of a separate yaml file (similar to the dynamic or diagnostic parameter file) in which the complete camera parameters are described and which are evaluated in the order as defined in the file. This should be considered as an alternative possibility to the launch parameters to configure a camera.

@boitumeloruf boitumeloruf added the feature New feature request label Dec 2, 2024
@rursprung
Copy link
Contributor

this would be nice as it'd also allow re-using the same config for multiple cameras (if they're identical, e.g. in a stereo setup). currently this involves copy & paste

@boitumeloruf
Copy link
Collaborator Author

In case of identical cameras, the use of nested launch files (i.e. one for camera type, that gets included twice for the two cameras of the stereo setup) could also be helpful.

@rursprung
Copy link
Contributor

to be fair: i can also just put it into a small wrapper function in the python launch file and call that to get the launch config for each node (incl. the necessary changes per-camera, e.g. the GUID). so i can already do the re-using now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

No branches or pull requests

2 participants